From e81c37a9b8c83d50deddc2124d5c868c531e0b0e Mon Sep 17 00:00:00 2001 From: Tetsuaki Hamano Date: Mon, 29 Apr 2024 14:01:45 +0900 Subject: [PATCH 1/9] GitHub Actions: Fix PHP file change detection filter pattern --- .github/workflows/php-changes-detection.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/php-changes-detection.yml b/.github/workflows/php-changes-detection.yml index dec97de5e87255..bed47bb6a20114 100644 --- a/.github/workflows/php-changes-detection.yml +++ b/.github/workflows/php-changes-detection.yml @@ -20,7 +20,7 @@ jobs: uses: tj-actions/changed-files@0874344d6ebbaa00a27da73276ae7162fadcaf69 # v44.3.0 with: files: | - **.{php} + **.php - name: List all changed files if: steps.changed-files-php.outputs.any_changed == 'true' From e1b521905bf53cddc142dff4abdebae0dd1f4ff6 Mon Sep 17 00:00:00 2001 From: Tetsuaki Hamano Date: Mon, 29 Apr 2024 14:07:03 +0900 Subject: [PATCH 2/9] Temporarily update PHP files --- lib/block-editor-settings.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/block-editor-settings.php b/lib/block-editor-settings.php index 53668e114e04cb..664fff1b4bff8d 100644 --- a/lib/block-editor-settings.php +++ b/lib/block-editor-settings.php @@ -5,6 +5,8 @@ * @package gutenberg */ +// Update! + /** * Replaces core 'styles' and '__experimentalFeatures' block editor settings from * wordpress-develop/block-editor.php with the Gutenberg versions. Much of the From 0bf364b7e63d2d3b7b2d03aecdbd32a07a3e1395 Mon Sep 17 00:00:00 2001 From: Tetsuaki Hamano Date: Mon, 29 Apr 2024 14:10:39 +0900 Subject: [PATCH 3/9] Revert temporary changes --- lib/block-editor-settings.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/block-editor-settings.php b/lib/block-editor-settings.php index 664fff1b4bff8d..53668e114e04cb 100644 --- a/lib/block-editor-settings.php +++ b/lib/block-editor-settings.php @@ -5,8 +5,6 @@ * @package gutenberg */ -// Update! - /** * Replaces core 'styles' and '__experimentalFeatures' block editor settings from * wordpress-develop/block-editor.php with the Gutenberg versions. Much of the From 453e8a2c1c48d9edf19957750bb8a67703e88e27 Mon Sep 17 00:00:00 2001 From: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Date: Wed, 8 May 2024 10:26:45 +0900 Subject: [PATCH 4/9] enclose the pattern in quotes Co-authored-by: Brian Alexander <824344+ironprogrammer@users.noreply.github.com> --- .github/workflows/php-changes-detection.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/php-changes-detection.yml b/.github/workflows/php-changes-detection.yml index bed47bb6a20114..f280da342b0a66 100644 --- a/.github/workflows/php-changes-detection.yml +++ b/.github/workflows/php-changes-detection.yml @@ -20,7 +20,7 @@ jobs: uses: tj-actions/changed-files@0874344d6ebbaa00a27da73276ae7162fadcaf69 # v44.3.0 with: files: | - **.php + '**.php' - name: List all changed files if: steps.changed-files-php.outputs.any_changed == 'true' From 58946ba0d494ec5d28c9fa2a59e791c8bb30e7d4 Mon Sep 17 00:00:00 2001 From: Tetsuaki Hamano Date: Wed, 8 May 2024 10:30:19 +0900 Subject: [PATCH 5/9] Updated some files to test GitHub action --- gutenberg.php | 2 ++ lib/blocks.php | 2 ++ packages/block-editor/src/autocompleters/link.js | 2 ++ packages/block-editor/src/autocompleters/style.scss | 2 ++ 4 files changed, 8 insertions(+) diff --git a/gutenberg.php b/gutenberg.php index dc7a76c1531ba1..6a6251ef9f6d33 100644 --- a/gutenberg.php +++ b/gutenberg.php @@ -12,6 +12,8 @@ * @package gutenberg */ +// Update gutenberg.php + ### BEGIN AUTO-GENERATED DEFINES defined( 'GUTENBERG_DEVELOPMENT_MODE' ) or define( 'GUTENBERG_DEVELOPMENT_MODE', true ); ### END AUTO-GENERATED DEFINES diff --git a/lib/blocks.php b/lib/blocks.php index eed9142db436a0..0aa7f755ad1c91 100644 --- a/lib/blocks.php +++ b/lib/blocks.php @@ -5,6 +5,8 @@ * @package gutenberg */ +// Update lib/blocks.php + /** * Substitutes the implementation of a core-registered block type, if exists, * with the built result from the plugin. diff --git a/packages/block-editor/src/autocompleters/link.js b/packages/block-editor/src/autocompleters/link.js index ce9af28f19d000..3289b61e429e4a 100644 --- a/packages/block-editor/src/autocompleters/link.js +++ b/packages/block-editor/src/autocompleters/link.js @@ -7,6 +7,8 @@ import apiFetch from '@wordpress/api-fetch'; import { addQueryArgs } from '@wordpress/url'; import { Icon, page, post } from '@wordpress/icons'; +// Update packages/block-editor/src/autocompleters/link.js + const SHOWN_SUGGESTIONS = 10; /** @typedef {import('@wordpress/components').WPCompleter} WPCompleter */ diff --git a/packages/block-editor/src/autocompleters/style.scss b/packages/block-editor/src/autocompleters/style.scss index 5380ddcfbe48b2..21152b311889dd 100644 --- a/packages/block-editor/src/autocompleters/style.scss +++ b/packages/block-editor/src/autocompleters/style.scss @@ -1,3 +1,5 @@ +// Update packages/block-editor/src/autocompleters/style.scss + .block-editor-autocompleters__block { white-space: nowrap; From 3a1c83e95ede74ddaebbfb8b02f366630c4c550e Mon Sep 17 00:00:00 2001 From: Tetsuaki Hamano Date: Wed, 8 May 2024 10:37:23 +0900 Subject: [PATCH 6/9] Remove quotes --- .github/workflows/php-changes-detection.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/php-changes-detection.yml b/.github/workflows/php-changes-detection.yml index d07e4246d650b3..9cb08e22f458c1 100644 --- a/.github/workflows/php-changes-detection.yml +++ b/.github/workflows/php-changes-detection.yml @@ -20,7 +20,7 @@ jobs: uses: tj-actions/changed-files@0874344d6ebbaa00a27da73276ae7162fadcaf69 # v44.3.0 with: files: | - '**.php' + **.php - name: List all changed files if: steps.changed-files-php.outputs.any_changed == 'true' From 6f639ebcad465945a69e0a70680ff21417ecda6d Mon Sep 17 00:00:00 2001 From: Tetsuaki Hamano Date: Wed, 8 May 2024 10:45:09 +0900 Subject: [PATCH 7/9] Undo unwanted changes --- gutenberg.php | 2 -- lib/blocks.php | 2 -- packages/block-editor/src/autocompleters/link.js | 2 -- packages/block-editor/src/autocompleters/style.scss | 2 -- 4 files changed, 8 deletions(-) diff --git a/gutenberg.php b/gutenberg.php index 6a6251ef9f6d33..dc7a76c1531ba1 100644 --- a/gutenberg.php +++ b/gutenberg.php @@ -12,8 +12,6 @@ * @package gutenberg */ -// Update gutenberg.php - ### BEGIN AUTO-GENERATED DEFINES defined( 'GUTENBERG_DEVELOPMENT_MODE' ) or define( 'GUTENBERG_DEVELOPMENT_MODE', true ); ### END AUTO-GENERATED DEFINES diff --git a/lib/blocks.php b/lib/blocks.php index 0aa7f755ad1c91..eed9142db436a0 100644 --- a/lib/blocks.php +++ b/lib/blocks.php @@ -5,8 +5,6 @@ * @package gutenberg */ -// Update lib/blocks.php - /** * Substitutes the implementation of a core-registered block type, if exists, * with the built result from the plugin. diff --git a/packages/block-editor/src/autocompleters/link.js b/packages/block-editor/src/autocompleters/link.js index 3289b61e429e4a..ce9af28f19d000 100644 --- a/packages/block-editor/src/autocompleters/link.js +++ b/packages/block-editor/src/autocompleters/link.js @@ -7,8 +7,6 @@ import apiFetch from '@wordpress/api-fetch'; import { addQueryArgs } from '@wordpress/url'; import { Icon, page, post } from '@wordpress/icons'; -// Update packages/block-editor/src/autocompleters/link.js - const SHOWN_SUGGESTIONS = 10; /** @typedef {import('@wordpress/components').WPCompleter} WPCompleter */ diff --git a/packages/block-editor/src/autocompleters/style.scss b/packages/block-editor/src/autocompleters/style.scss index 21152b311889dd..5380ddcfbe48b2 100644 --- a/packages/block-editor/src/autocompleters/style.scss +++ b/packages/block-editor/src/autocompleters/style.scss @@ -1,5 +1,3 @@ -// Update packages/block-editor/src/autocompleters/style.scss - .block-editor-autocompleters__block { white-space: nowrap; From b57fa24b0a7462b185e6be12e79186a6418d43f5 Mon Sep 17 00:00:00 2001 From: Tetsuaki Hamano Date: Sun, 12 May 2024 11:45:06 +0900 Subject: [PATCH 8/9] Change detection filter pattern --- .github/workflows/php-changes-detection.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/php-changes-detection.yml b/.github/workflows/php-changes-detection.yml index ef2bfa7c0e6378..cb78663aa4f972 100644 --- a/.github/workflows/php-changes-detection.yml +++ b/.github/workflows/php-changes-detection.yml @@ -19,8 +19,10 @@ jobs: id: changed-files-php uses: tj-actions/changed-files@0874344d6ebbaa00a27da73276ae7162fadcaf69 # v44.3.0 with: - files: | - **.php + files: | + lib/** + packages/**/*.php + phpunit/** - name: List all changed files if: steps.changed-files-php.outputs.any_changed == 'true' From f7fde90923c479e62c59aed9475c5181389e2c5c Mon Sep 17 00:00:00 2001 From: Tetsuaki Hamano Date: Sun, 12 May 2024 11:46:43 +0900 Subject: [PATCH 9/9] Add spaces --- .github/workflows/php-changes-detection.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/php-changes-detection.yml b/.github/workflows/php-changes-detection.yml index cb78663aa4f972..5a7749ee213817 100644 --- a/.github/workflows/php-changes-detection.yml +++ b/.github/workflows/php-changes-detection.yml @@ -19,10 +19,10 @@ jobs: id: changed-files-php uses: tj-actions/changed-files@0874344d6ebbaa00a27da73276ae7162fadcaf69 # v44.3.0 with: - files: | - lib/** - packages/**/*.php - phpunit/** + files: | + lib/** + packages/**/*.php + phpunit/** - name: List all changed files if: steps.changed-files-php.outputs.any_changed == 'true'