Inserter: Bail early when a user has no permission to upload media #60983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +16 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Apr 23, 2024
|
Thanks for the review, @ntsekouras!
100%. I would never block PR for extra spaces or for lacking a few :D |
|
Sorry, Nik. I miss clicked and failed to give you a props 🙇 |
|
No worries at all! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates logic flow in the
onMediaInsertcallback to display the modal early when inserting an external image, and the user has no permission to upload the media.I've also updated the component to get settings on-demand instead of creating a store subscription and added a few more extra spaces to let the code breathe.
Why?
It prevents making an unnecessary
GETrequest to fetch image data. Previously, fetching would error at the upload step due tosettings.mediaUploadbeingundefinedand trigger the modal.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast