test: Expand E2E test utilities #59214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
[Type] Automated Testing
2 tasks
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 5dea1345f90138db0b2c0e296284a1daf0c08c03. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8012648742
|
dcalhoun
force-pushed
the
test/expand-e2e-test-utilities
branch
from
b0dd8e2
to
5dea134
Compare
Simplify rendering a smaller Gallery block.
Simplify selecting a block via tapping it.
Some blocks contain nested pressables that need to be avoided for certain test cases.
Allowing composing offsets based upon the block dimensions, making it easier to target, e.g., the top-left corner.
Restructure the utility to reuse the existing `getBlockAtPosition` utility, encouraging composition of utilities rather than duplication.
dcalhoun
force-pushed
the
test/expand-e2e-test-utilities
branch
from
5dea134
to
b5324fc
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
geriux
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What?
Expand mobile end-to-end (E2E) test utilities.
Why?
Enable additional visual test case in the
gutenberg-mobilerepository.How?
selectBlockByTypeutilityselectBlockByTypeallows offsetting tap positionTesting Instructions
N/A, no user-facing changes.
Testing Instructions for Keyboard
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.