Font Library: Rename the slug of the google fonts collection from 'default-font-collection' to 'google-fonts' #58331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lection' to 'google-fonts'. No behaviour change is added. Only the slug name is updated.
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/fonts/font-library/font-library.php |
matiasbenedetto
added
[Type] Code Quality
|
Size Change: -8 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
creativecoder
approved these changes
Jan 26, 2024
creativecoder
added
the
Backport to Gutenberg RC
cbravobernal
pushed a commit
that referenced
this pull request
Jan 30, 2024
…lection' to 'google-fonts'. (#58331) No behaviour change is added. Only the slug name is updated.
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 0fa9cb1 |
cbravobernal
removed
the
Backport to Gutenberg RC
youknowriad
pushed a commit
that referenced
this pull request
Jan 31, 2024
…lection' to 'google-fonts'. (#58331) No behaviour change is added. Only the slug name is updated.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Rename the slug of the google fonts Font Collection from 'default-font-collection' to 'google-fonts'.
This just updates the slug of the collection no behaviour changes are expected with this PR.
Why?
To make the purpose of this font collection more explicit.
How?
Updating the slug
Testing Instructions