Fix/dataviews tooltip overlap #57026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +71 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
@mirka wanted to hear your thoughts about the approach here:
|
|
Flaky tests detected in 93b82cf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7198315632
|
|
I'm concerned about how scalable this solution is, given that we will have this problem with any kind of floating-ui in any scrolling container. I found that there is a relatively straightforward way to do this (#57062) as long as we have access to the floating-ui middleware. I think this approach is generic enough that we can just enable this auto-hiding behavior in all component instances, whether or not there are scrolling containers involved. What do you think? If you like it, I think we can propose adding this functionality to the Ariakit floating-uis (either baked in or as a customization). |
That is indeed a valid concern — the solution prototyped here is specific to the data views usecase, and it would need to be replicated every time it happens.
It's an interesting idea, and definitely a more generic approach (we'd need to consider carefully if we can foresee any edge cases or drawbacks), but I don't think it fully fixes the issue |
|
Closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #56939
What?
Experiment with fixing an issue with tooltip overlap
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast