Improve pre-publish checks naming consistency. #57019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
afercia
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad and
ajitbohra
as code owners
|
Size Change: +1 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 560ca68. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7194653513
|
carolinan
reviewed
Jan 3, 2024
afercia
force-pushed
the
fix/pre-publish-checks-naming-consistency
branch
from
560ca68
to
30268cd
Compare
carolinan
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56977
What?
Naming of the 'pre-publish' checks is greatly inconsistent across the UI: checks, checklist, flow.
Also, as a user I'm not supposed to know and understand what a
flowis. That is more technical / UX design jargon that should not be used in a user interface.Why?
Naming consistency is key for a good user experience.
How?
Standardizes the naming to
checksas that the simplest naming. Also, it's more easy to translate to other languages, whileflowis not well translatable.Testing Instructions
checks.Testing Instructions for Keyboard
Screenshots or screencast