-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block editor: hooks: share block settings #56852
Conversation
@@ -137,8 +133,7 @@ function BordersInspectorControl( { children, resetAllFilter } ) { | |||
); | |||
} | |||
|
|||
function BorderPanelPure( { clientId, name, setAttributes } ) { | |||
const settings = useBlockSettings( name ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if __unstableParentLayout
was forgotten here or intentionally omitted.
Size Change: -4 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
Flaky tests detected in e25a6ec. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7126857853
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool as well 👍
What?
Part of a larger effort to reduce store subscriptions per block (#56847), let's reuse the block settings subscription for all the style hooks.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast