Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: iterate on list view #56746

Merged
merged 30 commits into from
Dec 7, 2023
Merged

DataViews: iterate on list view #56746

merged 30 commits into from
Dec 7, 2023

Commits on Dec 5, 2023

  1. ViewList: bootstrap view with previewField and onClickPreviewField

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    d7b6a1a View commit details
    Browse the repository at this point in the history

  2. Remove dependency from View supports

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    047a1c7 View commit details
    Browse the repository at this point in the history

  3. Document API for preview

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    17b00d5 View commit details
    Browse the repository at this point in the history

  4. Let the previewField handle its render

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    448cd12 View commit details
    Browse the repository at this point in the history

  5. Use primaryField/preview from view.layout

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    4ab95f6 View commit details
    Browse the repository at this point in the history

  6. Take into account layout.preview to render interactivity hook & event… 

    … handler
    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    122b743 View commit details
    Browse the repository at this point in the history

  7. Remove preview field: the list view should always have a preview

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    494a1c9 View commit details
    Browse the repository at this point in the history

  8. onClickPreview to onSelectionChange

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    658e444 View commit details
    Browse the repository at this point in the history

  9. Fix up rebase

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a0254f1 View commit details
    Browse the repository at this point in the history

  10. Improve code legibility

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    623151f View commit details
    Browse the repository at this point in the history

  11. Do not pass the view to the render

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    98eee14 View commit details
    Browse the repository at this point in the history

  12. Make sure media field sizes are set for all views

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    e70540b View commit details
    Browse the repository at this point in the history

  13. Remove icon: it is meant to open the page details

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    58b2a57 View commit details
    Browse the repository at this point in the history

  14. Display other fields

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    e2fbf38 View commit details
    Browse the repository at this point in the history

  15. Display mediaField

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    6910c9f View commit details
    Browse the repository at this point in the history

  16. Document use of mediaField

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b822691 View commit details
    Browse the repository at this point in the history

  17. Styling

    @jameskoster
    jameskoster committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    4d6994b View commit details
    Browse the repository at this point in the history

  18. Use an element other than li as interactive

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    d0aaf51 View commit details
    Browse the repository at this point in the history

  19. Track selection

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b081b15 View commit details
    Browse the repository at this point in the history

  20. Do not render a link for the primary field in the list view

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    771f5f4 View commit details
    Browse the repository at this point in the history

  21. Media wrapper and list item margin

    @jameskoster
    jameskoster committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    32dcc5d View commit details
    Browse the repository at this point in the history

  22. Item interaction styles

    @jameskoster
    jameskoster committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    c0e1a36 View commit details
    Browse the repository at this point in the history

  23. Fix CSS lint issue

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    525c93c View commit details
    Browse the repository at this point in the history

  24. Selected item focus: use same styles as hover

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a8447bb View commit details
    Browse the repository at this point in the history

  25. Add keycodes to package-lock

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    1f72b36 View commit details
    Browse the repository at this point in the history

  26. Focus styles

    @jameskoster
    jameskoster committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    9013662 View commit details
    Browse the repository at this point in the history

  27. Heading weight

    @jameskoster
    jameskoster committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    ed554c5 View commit details
    Browse the repository at this point in the history

  28. Use formatListBullets for list view

    @jameskoster
    jameskoster committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    4d3a7f2 View commit details
    Browse the repository at this point in the history

  29. Button role: support SPACE

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    5621413 View commit details
    Browse the repository at this point in the history

  30. Button role: add aria-pressed

    @oandregal
    oandregal committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    4d0011d View commit details
    Browse the repository at this point in the history