Update status entity label to Status and plural to getStatuses
#55160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Code Quality
|
I consider this a "code quality" or even a bugfix, so I tagged it for 16.9, the same release as the original PR that introduce this new entity #55050 |
|
I wonder if the "post" prefix is limiting here? Can we have "statuses" in other things that are not "posts"? |
The REST API docs use If we want to be more general, I'm fine with doing |
|
Size Change: -4 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
|
@oandregal yeah I'm fine with either as well. just wanted to mention it in case you feel strongly one way or the other. |
|
Actually, and specially for the label. I prefer just "Status" personally because we do support status for things like "template", "template parts" (potentially global styles...). While these are "post types" internally, it's just an internal thing, for the user it's weird to have a "post status" for a "template"? |
youknowriad
approved these changes
Oct 9, 2023
oandregal
changed the title
status to postStatusStatus and plural to getStatuses
oandregal
changed the title
Status and plural to getStatusesStatus and plural to getStatuses
|
Flaky tests detected in 61aeaff. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6455956856
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #55050
Related #55158
What?
Updates the label of the status entity from
Post StatustoStatusand the pluralized form of the method togetStatuses.Why?
In preparing the documentation for
kind,name, andpluralproperties of the entity config, I've realized the dynamically created methods for the status entity were inconsistent:We should consolidate the word root to be
postStatus(hence the dynamic methods would begetPostStatusandgetPostStatus) orstatus(hence, they'd begetStatus,getStatuses).How?
Uses
statusas root everywhere: label, entity name, pluralized form.Testing Instructions
Extracted from #55050