Migrate 'iframed masonry block' tests to Playwright #55016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
commented
Oct 3, 2023
| const masonry = editor.canvas.getByRole( 'document', { | ||
| name: 'Block: Iframed Masonry Block', | ||
| } ); | ||
| await expect( masonry ).toBeVisible(); |
There was a problem hiding this comment.
I've replaced the snapshot assertion with this. Do we need to assert the block's whole edit markup?
There was a problem hiding this comment.
I don't think we do. If we want anything tested then we should probably add the assertions below anyway.
|
Size Change: +929 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Oct 3, 2023
kevin940726
approved these changes
Oct 4, 2023
| } ); | ||
| await expect( masonry ).toBeVisible(); | ||
|
|
||
| const masonryHeight = await masonry.evaluate( ( node ) => |
There was a problem hiding this comment.
Curious to know whether we can use boundingBox here?
There was a problem hiding this comment.
Good idea! Updated in 9a66431.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Closes #34773.
PR migrates 'iframed masonry block' tests to Playwright and simplifies it. Now that the editor loads in iframed by default, extra steps are unnecessary.
Why?
This is a part of general migration 🐦
Testing Instructions