Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles: Remove edit-post styles from editor components #5483

Merged
merged 2 commits into from
Mar 16, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Mar 7, 2018

Related: #4813 (comment)

This pull request seeks to eliminate direct references to edit-post from editor stylesheets. edit-post is intended as an extension of the underlying editor components, so it is not appropriate for editor to circularly reference edit-post.

As part of these changes, the Warning component has been updated to...

  • Not make assumptions about the type of content
  • Not force implementer to apply specific markup structure, instead providing actions if button options are intended

Testing instructions:

Verify that there are no regressions in...

  • Toolbar positioning for floated elements
  • Warning displays (try invalidating a block by removing classes from the cover image markup in post-content.js)
    • Particularly: Font size, family, and button placement

@aduth aduth added the Needs Design Feedback Needs general design feedback. label Mar 7, 2018
@aduth aduth merged commit 8e63479 into master Mar 16, 2018
@aduth aduth deleted the remove/editor-edit-post-references branch March 16, 2018 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant