Image block: Remove extra lookup for external image dimensions in lightbox #52178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user uses an external image, then we only know one set of dimensions, and we can use those dimensions from the image in the content for the lightbox. This commit adds logic to handle that scenario.
artemiomorales
added
[Type] Enhancement
|
Size Change: +22 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ce87aa5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5423803380
|
cbravobernal
approved these changes
Jun 30, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the lightbox, when dealing with external images, were doing a call to
wp_getimagesize()in order to get the dimensions needed to set the lightbox styles.However, we actually don't need to make the call, because when it comes to external images, the zoomed lightbox image is the same as the image in the content — and has the same dimensions.
This PR removes the call to
wp_getimagesize()and adds logic to handle this scenario.Why?
We should avoid making unnecessary network requests, especially with image files.
Fixes #52172
How?
It sets the 'width' and 'height' values to 'none' in the Interactivity API context, then adds a conditional to get the lightbox enlarged dimensions from the image in the content if the width and height values are unavailable.
Testing Instructions
Testing Instructions for Keyboard
N/A