Make the entire preview clickable in order to enter "edit" mode in focus mode. #51973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
getdave
changed the title
getdave
added
Backport to WP 6.7 Beta/RC
|
Size Change: +8 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9565b8d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5389426171
|
aaronrobertshaw
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Nice improvement @getdave 👍
This tests as advertised for me. I didn't spot any issues with animations, or the like, although I'm not super familiar with recent changes there.
All-in-all LGTM 🚢
| @@ -87,7 +87,9 @@ function EditorCanvas( { enableResizing, settings, children, ...props } ) { | |||
| // which isn't a requirement in auto resize mode. | |||
| enableResizing ? 'min-height:0!important;' : '' | |||
| }}body{position:relative; ${ | |||
| canvasMode === 'view' ? 'cursor: pointer;' : '' | |||
| canvasMode === 'view' | |||
| ? 'cursor: pointer; height: 100vh' | |||
There was a problem hiding this comment.
I'm not sure 100vh is the right way to go about this but min-height:100% isn't working and I don't understand why. If you manually add something like border: 10px solid yellow; to the body you will see scrollbars. I don't think this should block your PR but I'm going to investigate why min-height isn't working with how the HTML element is styled.
There was a problem hiding this comment.
Ok I see why, html needs to have height:100% instead of height: auto; for the min-height on body to work. But that produces scrollbars anyway on the edge case that I mentioned, so let's forget I said anything and go with your solution then. I doubt we will see many cases where this happens.
MaggieCabrera
approved these changes
Jun 28, 2023
|
I just cherry-picked this PR to the update/wp6-3-beta3 branch to get it included in the next release: ad1865a |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
tellthemachines
added a commit
that referenced
this pull request
Jul 3, 2023
* Footnotes: inscrease selector specificity for anchor (#52179) * Patterns: Include template parts for custom areas in Uncategorized category (#52159) * Fix custom patterns console error (#51947) * Fix error with react list key with new custom patterns list in inserter * Update placeholder key * Add comment to explain the different keys * Patterns: Fix missing custom patterns in patterns explorer (#51889) * Add custom patterns to pattern explorer * show custom patterns in the patterns explorer dialog * remove changes from 51877 * Fix up use of async lists * remove a bit of code duplication by adding a new hook * add 51877 fix back to make testing easier * Just assign the key value in one place * Refactor the custom patterns to use the usePatternsState hook * Fix use of async list * Translate strings and remove unneeded fields from pattern object * Try integrating unsynced patterns directly into pattern selectors (#51955) * Include reusable blocks with an undefined sync status in inserter items * Update docs * Remove change to hover dependencies --------- Co-authored-by: Daniel Richards <[email protected]> * i18n: Add context to the word "Filters" (#52198) * Update home template icon (#52075) * Centralise all permissions lookup in Link UI and enable (#52166) * BlockRemovalWarningModal: Fix incorrect '_n' usage (#52164) * Fix fetching Nav fallback ID flushing Navigation entity cache (#52069) * Only flush the `getEntityRecords` cache if the fallback isn’t already in state * Save the edited entity record to a const and then invert it to determine whether we should invalidate the recordds --------- Co-authored-by: scruffian <[email protected]> * Block Editor: Unify texts for Create pattern modal (#52151) * Fix history back after entering edit mode from Patterns (#52112) * Add template part icons to the library grid items (#51963) * Patterns: Fix sidebar tab label (#51953) * Patterns: Fix setting of sync status for fully synced patterns (#51952) * Library: Reinstate manage all template parts page (#51961) * Command Palette: fix incorrect path and snackbar message when template part is deleted (#52034) * Command Center: Fix incorrect navigation when deleting template part * removeTemplate: consider title type * Drop-indicator: remove white border. (#52122) * Make Navigation fallback selector private (#51413) * Move selector to become private * adds basic lock functionality * remove useless lock-unlock file * map private selectors to resolvers * Unlock the other usage * only create one fallback per session * Fix core-data duplicate private opt-in * Data: bind resolvers to selectors individually, support private selectors --------- Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: Jarda Snajdr <[email protected]> * Focus Mode: Use the symbol icon if a pattern is being edited (#52031) * Footnotes: register meta field for pages (#52024) * Fix unintentional toggling on of distraction free (#52090) * replace toggle with set preference - because I don't read code properly it seems * remove notification * Revert "Updating social link attributes (#51997)" (#52019) This reverts commit c711e2a. * Update home template name (#52048) * Removes unused call (#51988) * Remove ability for user to toggle sync status after pattern creation (#51998) * Fix disable DFM when opening styles command (#52165) * Update custom patterns label to 'My patterns' (#51949) * rename custom patterns to my patterns * Add my patterns label to inserter and show at the top --------- Co-authored-by: Daniel Richards <[email protected]> * Library: Add sync status to pattern details screen (#51954) * Patterns: Rename Library to Patterns (#52102) * [Library] Add lock icon for theme patterns (#51990) * Add lock icon for theme patterns * Change to class names * Add aria-description * Change wording * Patterns: Use "detached" copy consistently (#51993) * Editor initrial appender: Zero out margins in constrained layouts. (#52026) * Update pattern creation modal in library (#51946) * Fix missing snackbars in Library (#52021) * Make the entire preview clickable in order to enter "edit" mode in focus mode (#51973) * Page Content Focus: Add welcome guides (#52014) * Page Content Focus: Add welcome guides * Don't show when editor guide is active * Just use regular accent/theme color in all guides * slight copy change page guide * Update components changelog * Disable new guides in E2E tests * Use s.w.org videos --------- Co-authored-by: Saxon Fletcher <[email protected]> --------- Co-authored-by: Ella <[email protected]> Co-authored-by: Aaron Robertshaw <[email protected]> Co-authored-by: Glen Davies <[email protected]> Co-authored-by: Daniel Richards <[email protected]> Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: James Koster <[email protected]> Co-authored-by: Dave Smith <[email protected]> Co-authored-by: George Mamadashvili <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: Kai Hao <[email protected]> Co-authored-by: Carolina Nymark <[email protected]> Co-authored-by: Joen A <[email protected]> Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Jarda Snajdr <[email protected]> Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Ramon <[email protected]> Co-authored-by: Nik Tsekouras <[email protected]> Co-authored-by: Saxon Fletcher <[email protected]> Co-authored-by: Rich Tabor <[email protected]> Co-authored-by: Robert Anderson <[email protected]>
|
Kapture.2023-07-07.at.15.16.11.mp4Should it be |
|
This was merged in time for GB 16.2 RC 1, so no need for backporting to Gutenberg RC. |
ockham
removed
the
Backport to Gutenberg RC
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes the entire preview clickable in order to enter "edit" mode in focus mode.
Fixes #51794
Why?
Currently, despite the preview being full height, there is a bug whereby only clicking the actual blocks triggers edit mode.
Instead the entire window should be clickable to trigger edit mode. This PR fixes that.
This is particularly important for patterns/navigations which only have a single block.
How?
Sets the
bodyinviewmode to be100vhwhich resolves to "100% of the containing iframe". This ensures that thebodyexpands to fill the full height.Testing Instructions
Navigationand choose a menu.Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2023-06-27.at.12-50-14.mp4