Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block: Fix responsive sizing in lightbox #51823

Merged
merged 8 commits into from
Jun 29, 2023

Commits on Jun 28, 2023

  1. Configuration menu
    Copy the full SHA
    b34a6fa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0371a8 View commit details
    Browse the repository at this point in the history
  3. Use window inner dimensions to account for mobile address bar

    On mobile, the address bar is sometimes visible in browsers,
    which the CSS vh (viewport height) value does not account for.
    This causes calculations based on vh to render incorrectly
    if the address bar is ever visible - in this case, placing
    the lightbox image off center.
    
    To address this, I changed the lightbox calculations to be
    based on window.innerHeight and window.innerWidth instead.
    artemiomorales committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    ce931b2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    49181a5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    58a11a2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    af76853 View commit details
    Browse the repository at this point in the history
  7. Revert "Use built-in directive for mouseover event"

    This reverts commit a4c9a22ccd17fc92f5dd99796b52605654ce82e9.
    artemiomorales committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    a562af9 View commit details
    Browse the repository at this point in the history
  8. Update tests

    artemiomorales committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    f1971e3 View commit details
    Browse the repository at this point in the history