Site editor: Add a navigable region for content area of Library and Template views #51782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
This also seems to fix the 'Manage all templates' view, which uses the My search skills failed me initially, so I didn't realise edit: I've updated the PR description |
talldan
changed the title
|
Size Change: +43 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7cf608296adea8f236514a6370df3b28310869d3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5342501276
|
aaronrobertshaw
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Nice improvement @talldan, thank you 👍
✅ Code changes look good
✅ Can navigate between regions on Library page
✅ Can navigate between regions on Templates/Manage all templates pages
🚢
talldan
force-pushed
the
fix/add-navigable-region-for-library-content
branch
from
7cf6082 to
b116b86
Compare
talldan
added
Backport to WP 6.7 Beta/RC
tellthemachines
removed
Backport to WP 6.7 Beta/RC
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
|
Is there a reason that this is set up as |
I don't have much history or context here, however, this PR didn't introduce the navigable region around the sidebar which includes navigation. It appears that the region in question was labelled "Navigation sidebar" originally and later renamed to "Navigation" in #49614. There might be some answers there. My guess for the reasoning behind using
This area isn't a strong suit of mine, so please take that with a grain of salt. If we need to make some changes, I think a dedicated issue would be the best course. |
priethor
added
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a navigable region to the Library content area and the Template content area (when you navigate to 'Manage all templates')
Why?
It's a useful aid for keyboard/screenreader users to jump between parts of the screen
How?
There seems to be a
Pagecomponent that look perfect for this purpose. It already receives atitle, so I've used that for the navigable region label.Testing Instructions for Keyboard
Expected: There are two regions that are announced correctly, 'Navigation' and 'Library content'.
Expected: There are two regions that are announced correctly, 'Navigation' and 'Templates'.
Screenshots or screencast
There's no visible difference