Site Editor: Fix gradient background color repeats #51374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +7 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
t-hamano
added
Global Styles
|
Flaky tests detected in a6f0c0e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5221992164
|
jasmussen
approved these changes
Jun 12, 2023
|
I would appreciate another quick code sanity check before you merge. |
|
I feel we've been going back and forth on some of these things but I can't break this in any way so LGTM too. |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
5 tasks
|
Sorry to come back to this. While testing background styles over in #59354 (comment), it became apparent that having a min-height on the For example, the repeating background will still occur on the frontend despite the editor rule: 
It's not such a big deal I guess, but it more apparent when the background is an image. How closely do we want the site editor and frontend to match? |
I think we want them to match as closely as possible. If this is considered a bug in the editor, it should be considered a bug in the frontend too. |
Thanks, there's a discussion over in #59354 (comment) about adding a min-height by default on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #46782
What?
This PR fixes a problem in the site editor where the background gradient repeats when the content is less than the height of the canvas.
Why?
I have created some simple HTML to try to figure out the cause of this problem.
The height of the
bodyelement is 100px. And the same goes forhtmlelements. However, when you define a background color on thebodyelement, that background goes beyond thehtmlelement and fills the entire page.This behavior does not occur with any element within the body element. I have also observed this problem in both Chrome and Firefox.
How?
I found that this problem does not occur when the
htmlelement is above the document height. Therefore, I addedmin-height:100%.Testing Instructions
Screenshots or screencast