From 92e8b2b6cdd8814f5d2121a8ec4d9782f780161e Mon Sep 17 00:00:00 2001 From: jasmussen Date: Wed, 10 May 2023 08:53:19 +0200 Subject: [PATCH 1/4] Button: Update disabled state to be without background. --- packages/components/src/button/style.scss | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/packages/components/src/button/style.scss b/packages/components/src/button/style.scss index 3ec844906b0390..aa0fe0d8c776ec 100644 --- a/packages/components/src/button/style.scss +++ b/packages/components/src/button/style.scss @@ -118,21 +118,15 @@ outline: 1px solid transparent; &:active:not(:disabled) { - background: $components-color-gray-300; - color: $components-color-accent-darker-10; box-shadow: none; } - &:hover:not(:disabled) { - color: $components-color-accent-darker-10; - } - &:disabled, &[aria-disabled="true"], &[aria-disabled="true"]:hover { // TODO: Prepare for theming (https://github.com/WordPress/gutenberg/pull/45466/files#r1030872724) - color: lighten($gray-700, 5%); - background: lighten($gray-300, 5%); + color: $gray-600; + background: transparent; transform: none; opacity: 1; box-shadow: none; @@ -165,12 +159,12 @@ color: $components-color-accent; background: transparent; - &:hover:not(:disabled) { + &:hover:not(:disabled, [aria-disabled="true"]) { // TODO: Prepare for theming (https://github.com/WordPress/gutenberg/pull/45466/files#r1030872724) background: rgba(var(--wp-admin-theme-color--rgb), 0.04); } - &:active:not(:disabled) { + &:active:not(:disabled, [aria-disabled="true"]) { // TODO: Prepare for theming (https://github.com/WordPress/gutenberg/pull/45466/files#r1030872724) background: rgba(var(--wp-admin-theme-color--rgb), 0.08); } @@ -239,7 +233,7 @@ } } - &:not([aria-disabled="true"]):active { + &:not(:disabled, [aria-disabled="true"]):active { color: $components-color-foreground; } From 7861590afa681b0ec300fcf6ed5f540708a261d3 Mon Sep 17 00:00:00 2001 From: jasmussen Date: Wed, 10 May 2023 08:58:02 +0200 Subject: [PATCH 2/4] Update changelog. --- packages/components/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 5d48196f04bccf..247bedf3b695a3 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +### Bug Fix + +- Update `