From 2694213a6d9196ff602be5dfd4bc6fac6e18db49 Mon Sep 17 00:00:00 2001 From: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Date: Wed, 22 Feb 2023 15:08:44 +1100 Subject: [PATCH 1/2] Site Tagline: Add example so that it will display in style book --- packages/block-library/src/site-tagline/index.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/block-library/src/site-tagline/index.js b/packages/block-library/src/site-tagline/index.js index 1d0090f9dcea19..b002a348057d8a 100644 --- a/packages/block-library/src/site-tagline/index.js +++ b/packages/block-library/src/site-tagline/index.js @@ -13,6 +13,7 @@ export { metadata, name }; export const settings = { icon, edit, + example: {}, deprecated, }; From 94f8dfbf3f1096783bf9bf5adb4d25e2ffa39ac5 Mon Sep 17 00:00:00 2001 From: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Date: Wed, 22 Feb 2023 15:23:16 +1100 Subject: [PATCH 2/2] Add placeholder attribute --- docs/reference-guides/core-blocks.md | 2 +- packages/block-library/src/site-tagline/block.json | 3 +++ packages/block-library/src/site-tagline/edit.js | 4 ++-- packages/block-library/src/site-tagline/index.js | 11 ++++++++++- 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/docs/reference-guides/core-blocks.md b/docs/reference-guides/core-blocks.md index 2917c8577b07da..7708f57a8a7670 100644 --- a/docs/reference-guides/core-blocks.md +++ b/docs/reference-guides/core-blocks.md @@ -744,7 +744,7 @@ Describe in a few words what the site is about. The tagline can be used in searc - **Name:** core/site-tagline - **Category:** theme - **Supports:** align (full, wide), anchor, color (background, gradients, text), spacing (margin, padding), typography (fontSize, lineHeight), ~~html~~ -- **Attributes:** textAlign +- **Attributes:** placeholder, textAlign ## Site Title diff --git a/packages/block-library/src/site-tagline/block.json b/packages/block-library/src/site-tagline/block.json index c7da7ebf3fddeb..64a1f11f5d029f 100644 --- a/packages/block-library/src/site-tagline/block.json +++ b/packages/block-library/src/site-tagline/block.json @@ -8,6 +8,9 @@ "keywords": [ "description" ], "textdomain": "default", "attributes": { + "placeholder": { + "type": "string" + }, "textAlign": { "type": "string" } diff --git a/packages/block-library/src/site-tagline/edit.js b/packages/block-library/src/site-tagline/edit.js index 1ce13c6eb43c49..7fe00ab63c859d 100644 --- a/packages/block-library/src/site-tagline/edit.js +++ b/packages/block-library/src/site-tagline/edit.js @@ -22,7 +22,7 @@ export default function SiteTaglineEdit( { setAttributes, insertBlocksAfter, } ) { - const { textAlign } = attributes; + const { placeholder, textAlign } = attributes; const { canUserEdit, tagline } = useSelect( ( select ) => { const { canUser, getEntityRecord, getEditedEntityRecord } = select( coreStore ); @@ -57,7 +57,7 @@ export default function SiteTaglineEdit( { allowedFormats={ [] } onChange={ setTagline } aria-label={ __( 'Site tagline text' ) } - placeholder={ __( 'Write site taglineā€¦' ) } + placeholder={ placeholder || __( 'Write site taglineā€¦' ) } tagName="p" value={ tagline } disableLineBreaks diff --git a/packages/block-library/src/site-tagline/index.js b/packages/block-library/src/site-tagline/index.js index b002a348057d8a..0a8b99698dd519 100644 --- a/packages/block-library/src/site-tagline/index.js +++ b/packages/block-library/src/site-tagline/index.js @@ -1,3 +1,8 @@ +/** + * WordPress dependencies + */ +import { __ } from '@wordpress/i18n'; + /** * Internal dependencies */ @@ -13,7 +18,11 @@ export { metadata, name }; export const settings = { icon, edit, - example: {}, + example: { + attributes: { + placeholder: __( 'A site tagline.' ), + }, + }, deprecated, };