Writing flow: absorb partial multi selection dispatching #47525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +596 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f19a197. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7220611211
|
ellatrix
force-pushed
the
try/writing-flow-selection-observer
branch
from
25a9b42
to
4a6bf42
Compare
ellatrix
force-pushed
the
try/writing-flow-selection-observer
branch
from
4a6bf42
to
70bc49f
Compare
ellatrix
force-pushed
the
try/writing-flow-selection-observer
branch
from
50f26dc
to
4a1ec8e
Compare
ellatrix
added
[Type] Performance
ntsekouras
reviewed
Dec 12, 2023
| @@ -84,6 +88,16 @@ export default function useDragSelection() { | |||
| return; | |||
| } | |||
|
|
|||
| // Abort if we are already multi-selecting. | |||
| if ( isMultiSelecting() ) { | |||
| return; | |||
There was a problem hiding this comment.
This is the reason we can't continue with the selection after having started a multi selection, right?
Screen.Recording.2023-12-12.at.11.18.11.AM.mov
There was a problem hiding this comment.
I fixed this :)
It's actually a bit broken in trunk too
ellatrix
force-pushed
the
try/writing-flow-selection-observer
branch
from
e45afef
to
14da1e1
Compare
ellatrix
commented
Dec 19, 2023
| position: { x: -1, y: 0 }, | ||
| // Use force since it's outside the bounding box of the element. | ||
| force: true, | ||
| } ); |
There was a problem hiding this comment.
Note that I am merely making things consistent here with the Esc shortcut:
gutenberg/packages/block-editor/src/components/block-tools/index.js
Lines 163 to 170 in 395b18f
ellatrix
added
[Type] Bug
youknowriad
approved these changes
Dec 20, 2023
|
I think this PR introduced a very small regression for the "block select" metric. It's like 8% maybe. Could be acceptable though. |
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently we dispatch selection start/end from the rich text instances for partial selection. This PR moves this logic to writing flow, which is responsible for partial selection handling.
Why?
Currently each rich text instance adds a global selection change listener. With this change, only two selection change handlers remain: one in writing flow and one for the selected rich text element.
It should improve both load and typing performance. We currently do not measure the
selectionchangeevent though. This can happen async when typing fast, but when it happens, it will block the next event.Additionally it makes writing flow and rich text more independent. We shouldn't have writing flow logic inside rich text.
It also fixes this issue:
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast