From 2b3229a05efab81403179fa1df5022b996802546 Mon Sep 17 00:00:00 2001 From: chad1008 <13856531+chad1008@users.noreply.github.com> Date: Thu, 2 Jun 2022 06:27:19 -0400 Subject: [PATCH 1/3] Draggable: update `useEffect` dependency array --- packages/components/src/draggable/index.native.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/src/draggable/index.native.js b/packages/components/src/draggable/index.native.js index a9cc6b40070ed4..4d9513a47e3654 100644 --- a/packages/components/src/draggable/index.native.js +++ b/packages/components/src/draggable/index.native.js @@ -142,7 +142,7 @@ const Draggable = ( { const providerValue = useMemo( () => { return { panGestureRef, isDragging, isPanActive, draggingId }; - }, [] ); + }, [ isDragging, isPanActive, draggingId ] ); return ( From 856728033805ba193d17f085531f154e94739ee6 Mon Sep 17 00:00:00 2001 From: chad1008 <13856531+chad1008@users.noreply.github.com> Date: Thu, 2 Jun 2022 06:39:43 -0400 Subject: [PATCH 2/3] Draggable: update changelog (merge conflict) --- packages/components/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index a367b8f49d23e2..0d8cccf67939f2 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -41,6 +41,8 @@ - `Surface`: Convert to TypeScript ([#41212](https://github.com/WordPress/gutenberg/pull/41212)). - `Autocomplete` updated to satisfy `react/exhuastive-deps` eslint rule ([#41382](https://github.com/WordPress/gutenberg/pull/41382)) - `DateDayPicker` updated to satisfy `react/exhuastive-deps` eslint rule ([#41470](https://github.com/WordPress/gutenberg/pull/41470)). +- `Draggable` updated to satisfy `react/exhuastive-deps` eslint rule ([#41499](https://github.com/WordPress/gutenberg/pull/41499)) + ### Experimental - `Spacer`: Add RTL support. ([#41172](https://github.com/WordPress/gutenberg/pull/41172)) From 43336072531bdd8569e576de7d3516ebeb797b93 Mon Sep 17 00:00:00 2001 From: chad1008 <13856531+chad1008@users.noreply.github.com> Date: Wed, 8 Jun 2022 06:52:00 -0400 Subject: [PATCH 3/3] move changelog update to the correct section --- packages/components/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 0d8cccf67939f2..4d14a5bf4692ef 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -11,6 +11,7 @@ ### Internal - `FormTokenField`: Convert to TypeScript and refactor to functional component ([#41216](https://github.com/WordPress/gutenberg/pull/41216)). +- `Draggable` updated to satisfy `react/exhuastive-deps` eslint rule ([#41499](https://github.com/WordPress/gutenberg/pull/41499)) ## 19.12.0 (2022-06-01) @@ -41,7 +42,6 @@ - `Surface`: Convert to TypeScript ([#41212](https://github.com/WordPress/gutenberg/pull/41212)). - `Autocomplete` updated to satisfy `react/exhuastive-deps` eslint rule ([#41382](https://github.com/WordPress/gutenberg/pull/41382)) - `DateDayPicker` updated to satisfy `react/exhuastive-deps` eslint rule ([#41470](https://github.com/WordPress/gutenberg/pull/41470)). -- `Draggable` updated to satisfy `react/exhuastive-deps` eslint rule ([#41499](https://github.com/WordPress/gutenberg/pull/41499)) ### Experimental