List block v2: Fixes an issue where pressing enter deletes innerblocks. #41109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
|
Size Change: +40 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
May 17, 2022
There was a problem hiding this comment.
It works as expected 👍
P.S. I didn't know that the onSplit callback accepted the second argument. It looks like RichText docs are out of date.
Before
CleanShot.2022-05-17.at.17.43.28.mp4
After
CleanShot.2022-05-17.at.17.44.46.mp4
jorgefilipecosta
deleted the
fix/list-block-v2-pressing-enter-deletes-nested-items
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where pressing enter on list block v2 deletes the nested blocks.
Testing Instructions
I added list blocks with nested items pressed enter and verified the nested items were not deleted.