Tooling: Fix commands containing dot-slashes in npm scripts #39739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.22 MB ℹ️ View Unchanged
|
|
Hello @t-hamano, can you rebase this branch with the latest changes from |
t-hamano
force-pushed
the
fix/npm-dot-slash
branch
from
ac2b810 to
a5f4a40
Compare
|
@gziolo |
gziolo
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #39388
What?
In this pull PR, I explicitly add
nodeandbashcommands in the execution of npm scripts.Why?
As mentioned in the npm repository issue, commands containing dot-slashes cannot be executed by default, so it seems necessary to specify explicitly what command to use in Windows.
Testing Instructions
The following four scripts were fixed in this PR.
Although there may be some differences depending on the OS and environment, the following logs should be displayed correctly.
✅ build:plugin-zip
"bash ./bin/build-plugin-zip.sh"⚠ Note: It may take a considerable amount of time, because this script delete files outside of git control ( such as node_modules ) and reinstall npm packages.
✅ changelog
"node ./bin/plugin/cli.js changelog"Change logs should be output:
✅ test-unit:date
"bash ./bin/unit-test-date.sh"Should pass all tests:
( It may take several minutes for the log to appear depending on your environment and computer specs. )
✅ test:create-block
"bash ./bin/test-create-block.sh"Block generation, build, linting, and zip file generation should complete successfully: