Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-entity save UI: Add Discard Changes panel #36185

Draft
wants to merge 25 commits into
base: trunk
Choose a base branch
from
Draft

Multi-entity save UI: Add Discard Changes panel #36185

wants to merge 25 commits into from
+385 −29

Commits on Nov 17, 2021

  1. Multi-entity save UI: Add Discard Changes panel

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    4d9e22e View commit details
    Browse the repository at this point in the history

  2. Discard changes i1

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    83b7a22 View commit details
    Browse the repository at this point in the history

  3. Make work for site entities

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    68e2330 View commit details
    Browse the repository at this point in the history

  4. Remove commented-out code

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    cb74cac View commit details
    Browse the repository at this point in the history

  5. No need to set an actual value

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    f853b40 View commit details
    Browse the repository at this point in the history

  6. Change implementation to use EDIT_ENTITY_RECORD

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    57cb2a6 View commit details
    Browse the repository at this point in the history

  7. Add unit test

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    58cfd81 View commit details
    Browse the repository at this point in the history

  8. Change implementation to use EDIT_ENTITY_RECORD

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    3bd1bd9 View commit details
    Browse the repository at this point in the history

  9. Fix unit test

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    de6e041 View commit details
    Browse the repository at this point in the history

  10. Add unit test for __experimentalResetEditedEntityRecord

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    824f18d View commit details
    Browse the repository at this point in the history

  11. Close panel upon clicking either button

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    0e22179 View commit details
    Browse the repository at this point in the history

  12. Move DiscardEntityChangesPanel to dedicated file

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    cdd8665 View commit details
    Browse the repository at this point in the history

  13. Fix some criteria

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    aafd659 View commit details
    Browse the repository at this point in the history

  14. Simplify

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    27b0962 View commit details
    Browse the repository at this point in the history

  15. Some polish

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    96aa60c View commit details
    Browse the repository at this point in the history

  16. Style fix

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    7c4811c View commit details
    Browse the repository at this point in the history

  17. Simplify

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    961b1fc View commit details
    Browse the repository at this point in the history

  18. Filter records that are being saved

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    8fb7441 View commit details
    Browse the repository at this point in the history

  19. Remove 'Continue editing' button, adapt wording accordingly

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    e104770 View commit details
    Browse the repository at this point in the history

  20. Add 'Template updated!' message

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    c5c63a8 View commit details
    Browse the repository at this point in the history

  21. Add grey line

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    847789e View commit details
    Browse the repository at this point in the history

  22. Add saving animation

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    8e1fbf0 View commit details
    Browse the repository at this point in the history

  23. Add snackbar notification

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    d4eb3d7 View commit details
    Browse the repository at this point in the history

  24. Simplify isSaving logic

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    7a6b3f3 View commit details
    Browse the repository at this point in the history

  25. Template-agnostic wording

    @ockham
    ockham committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    b9deaea View commit details
    Browse the repository at this point in the history