From 46ff3f4114037ad1bf3f83b4b97090833e33bf50 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Albert=20Juh=C3=A9=20Lluveras?= Date: Mon, 8 Mar 2021 16:11:06 +0100 Subject: [PATCH 1/2] Don't display Guide's page control if there is only one page --- packages/components/src/guide/index.js | 12 +++++++----- packages/components/src/guide/test/index.js | 7 +++++++ 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/packages/components/src/guide/index.js b/packages/components/src/guide/index.js index 4bbc7198b668a7..f16cd25456494d 100644 --- a/packages/components/src/guide/index.js +++ b/packages/components/src/guide/index.js @@ -78,11 +78,13 @@ export default function Guide( {
{ pages[ currentPage ].image } - + { pages.length > 1 && ( + + ) } { pages[ currentPage ].content } diff --git a/packages/components/src/guide/test/index.js b/packages/components/src/guide/test/index.js index f2e1a584c7ca35..0e38f63c20037e 100644 --- a/packages/components/src/guide/test/index.js +++ b/packages/components/src/guide/test/index.js @@ -71,6 +71,13 @@ describe( 'Guide', () => { ).toHaveLength( 1 ); } ); + it( "doesn't display the page control if there is only one page", () => { + const wrapper = shallow( + Page 1

} ] } /> + ); + expect( wrapper.find( PageControl ).exists() ).toBeFalsy(); + } ); + it( 'calls onFinish when the finish button is clicked', () => { const onFinish = jest.fn(); const wrapper = shallow( From 0828227c3133d09cc512cd6f579cd695d7259917 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Albert=20Juh=C3=A9=20Lluveras?= Date: Mon, 8 Mar 2021 16:45:24 +0100 Subject: [PATCH 2/2] Tweak margins so Guide contents don't rely on the PageControl margins --- packages/components/src/guide/style.scss | 4 +++- packages/edit-post/src/components/welcome-guide/style.scss | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/components/src/guide/style.scss b/packages/components/src/guide/style.scss index b2ca62dcb2ac7d..305c339da364b9 100644 --- a/packages/components/src/guide/style.scss +++ b/packages/components/src/guide/style.scss @@ -62,16 +62,18 @@ } &__page-control { - margin: $grid-unit-10 0 $grid-unit-10 0; + margin: 0; text-align: center; li { display: inline-block; + margin: 0; } .components-button { height: 30px; min-width: 20px; + margin: -6px 0; } } diff --git a/packages/edit-post/src/components/welcome-guide/style.scss b/packages/edit-post/src/components/welcome-guide/style.scss index f76ae8bd9536c3..1697a694b6291e 100644 --- a/packages/edit-post/src/components/welcome-guide/style.scss +++ b/packages/edit-post/src/components/welcome-guide/style.scss @@ -6,6 +6,7 @@ &__image { background: #00a0d2; height: 240px; + margin: 0 0 $grid-unit-20; &__prm-r { display: none; @@ -26,7 +27,7 @@ font-family: $default-font; font-size: 24px; line-height: 1.4; - margin: 0 0 $grid-unit-20 0; + margin: $grid-unit-20 0 $grid-unit-20 0; padding: 0 $grid-unit-40; }