e2e: Fix multi entity editing test #27347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Feature] Full Site Editing
[Package] E2E Tests
noahtallen
requested review from
youknowriad,
aristath,
david-szabo97 and
Addison-Stavlo
|
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
6 tasks
6 tasks
6 tasks
tellthemachines
approved these changes
Nov 30, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #27303, the behavior of template resolution was changed such that a custom manually-created user template no longer overrides a theme template which has the same slug. This breaks the test because the test assumes two things:
front-pagewill always be used instead of the theme template with the same slug.These assumptions should not be taken by the test, so we need to make it more robust. The failure always seems unrelated since these PRs continue to be merged. :P This PR fixes the issue by using a user created custom template which doesn't correspond to the template hierarchy. This way, it's not possible for a theme file to conflict with it. This test is only concerned with making sure that entity save states work correctly, so this is a fine approach for this test.
We should also follow up to create tests which cover the template resolution hierarchy so that it is more obvious when we are breaking it in some way or another. Currently I don't think we cover template priorities at all with tests. We definitely shouldn't rely on some unrelated test to inform us when it is broken :P
How has this been tested?
The multi entity editing test should pass. (I verified it does locally.)
Screenshots
Types of changes
Fix
Checklist: