Size Change: -16 B (0%)

Total Size: 1.19 MB

_{compressed-size-action}

At some point, we converted this package to ESM but we reverted it back to ES5 because of some breaking changes introduced. See: #8132.

It shouldn't be an issue anymore, now that #18942 landed with a new major version that removed this limitation.

Some tools might still assume that is-shallow-equal is ES5 based, so we will have to update that as well. Although, I couldn't find any place that would be affected. It looks like we made configuration for tools more flexible :)

I checked 2 failing E2E jobs for mobile apps and it looks like those are valid issues to resolve.

@gziolo Any ideas how to address this? At first I thought it was merely a resolution issue as the original error stated something along the lines of:

Unable to resolve ".../index.js(index.js|.js|...)"

I assumed the issue here was a double .js.

I added a react-native entry to the package.json to match other packages I observed doing the same thing, but that did not resolve the issue 🤔 Any help would be appreciated!

@sirreal Good catch! I've updated it. There's no reason to distribute the benchmark and test files I don't believe.

Package lock problems now, maybe a rebase 😕

I tried to run benchmarks as noted in the README file
(https://github.com/WordPress/gutenberg/blob/master/packages/is-shallow-equal/README.md#benchmarks)

It needs to be updated to include the step that builds packages:

cd packages/packages/is-shallow-equal
npm install
npm run build:packages
node benchmark

You might see the following issue when you run the benchmark for the first time:

(node:65044) UnhandledPromiseRejectionWarning: Error: Cannot find module '@wordpress/lazy-import.5ab856344c555e50779f56b4cd1f2e02'

It's a known issue. All subsequent runs should work as expected.

There is an issue with importing code using CJS:

https://github.com/WordPress/gutenberg/blob/master/packages/is-shallow-equal/benchmark/index.js#L43-L44

This code probably errors as I no longer see benchmark results:

@wordpress/is-shallow-equal (object, equal): 
@wordpress/is-shallow-equal (object, same): 
@wordpress/is-shallow-equal (object, unequal): 
@wordpress/is-shallow-equal (array, equal): 
@wordpress/is-shallow-equal (array, same): 
@wordpress/is-shallow-equal (array, unequal):

@gziolo Thanks for catching that. I've fixed the issue and noted that there is now a breaking change (really glad you tried out the benchmark).

I also updated the description to note that the benchmarks are different from the README's. This is true of master as of this branch (though there is no significant difference between this branch and master). Shall I also update the README with new benchmarks?

@sirreal Can you re-review this PR? It's blocked on your change request (which I addressed 🙂)