From 030114bda256aa4b419577607a848156e1d6cee8 Mon Sep 17 00:00:00 2001 From: Enrique Piqueras Date: Mon, 10 Feb 2020 11:48:23 -0500 Subject: [PATCH] Project Management Automation: Guard against non-matching commits in `addMilestone`. Fixes #20144. --- packages/project-management-automation/lib/add-milestone.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/project-management-automation/lib/add-milestone.js b/packages/project-management-automation/lib/add-milestone.js index 85e5784bff77a4..e7dc6cef3c4b6f 100644 --- a/packages/project-management-automation/lib/add-milestone.js +++ b/packages/project-management-automation/lib/add-milestone.js @@ -41,7 +41,8 @@ async function addMilestone( payload, octokit ) { return; } - const [ , prNumber ] = payload.commits[ 0 ].message.match( /\(#(\d+)\)$/m ); + const match = payload.commits[ 0 ].message.match( /\(#(\d+)\)$/m ); + const prNumber = match && match[ 1 ]; if ( ! prNumber ) { debug( 'add-milestone: Commit is not a squashed PR. Aborting' ); return;