From 7f3476a9b3b99af089bbc27a064c992468943a05 Mon Sep 17 00:00:00 2001 From: Leandro Alonso Date: Thu, 30 Jan 2020 08:07:32 -0300 Subject: [PATCH 1/2] Only shows the media edit icon if the block is selected Also, matches the style of the native gallery block buttons --- packages/block-library/src/image/edit.native.js | 10 ++++++---- .../src/image/icon-customize.native.js | 2 +- .../block-library/src/image/styles.native.scss | 16 ++++++++++++---- 3 files changed, 19 insertions(+), 9 deletions(-) diff --git a/packages/block-library/src/image/edit.native.js b/packages/block-library/src/image/edit.native.js index 7f27f99dd1de39..6928494c9ab3f2 100644 --- a/packages/block-library/src/image/edit.native.js +++ b/packages/block-library/src/image/edit.native.js @@ -400,9 +400,11 @@ export class ImageEdit extends React.Component { const editImageComponent = ( { open, mediaOptions } ) => ( - - { mediaOptions() } - + + + { mediaOptions() } + + ); @@ -471,7 +473,7 @@ export class ImageEdit extends React.Component { { retryMessage } } - { ! isUploadInProgress && ! isUploadFailed && finalWidth && finalHeight && showMediaEditorButton && + { isSelected && ! isUploadInProgress && ! isUploadFailed && finalWidth && finalHeight && showMediaEditorButton && ; +export default ; diff --git a/packages/block-library/src/image/styles.native.scss b/packages/block-library/src/image/styles.native.scss index a34c48fb7bbbc4..d4c512ea423cdd 100644 --- a/packages/block-library/src/image/styles.native.scss +++ b/packages/block-library/src/image/styles.native.scss @@ -84,10 +84,18 @@ align-items: center; } -.edit { +.editContainer { width: 44px; height: 44px; - background-color: $dark-opacity-500; + position: absolute; + top: 0; + right: 0; +} + +.edit { + width: 30px; + height: 30px; + background-color: $gray-dark; border-radius: 22px; position: absolute; top: 5px; @@ -97,6 +105,6 @@ .iconCustomise { fill: #fff; position: absolute; - top: 10px; - left: 10px; + top: 7px; + left: 7px; } From 03123f0f67626312d8199588c2a0ceab813436d0 Mon Sep 17 00:00:00 2001 From: Leandro Alonso Date: Fri, 31 Jan 2020 10:02:52 -0300 Subject: [PATCH 2/2] Fix lint --- packages/block-library/src/image/icon-customize.native.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-library/src/image/icon-customize.native.js b/packages/block-library/src/image/icon-customize.native.js index d1add59bd94498..57fc39c7c29f1b 100644 --- a/packages/block-library/src/image/icon-customize.native.js +++ b/packages/block-library/src/image/icon-customize.native.js @@ -4,7 +4,7 @@ import { Path, SVG } from '@wordpress/components'; export default ( - + );