Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick tags buttons need to be properly labeled (regression from current editor) #979

Closed
afercia opened this issue Jun 1, 2017 · 2 comments
Labels
[Feature] Code Editor Handling the code view of the editing experience [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Jun 1, 2017

In the current WordPress text editor, the QuickTags buttons are properly labeled (the labels are also translatable):

screen shot 2017-06-01 at 18 31 47

In Gutenberg, they're not (yet?):

screen shot 2017-06-01 at 18 31 28

The current rendered markup is, for example:
<button class="editor-text-editor__bold">b</button>

All these buttons need aria-label attributes with translatable strings, as in the current text editor.
To evaluate: do they need also a type="button" attribute?

Aside: as mentioned in another issue, personally I'm not fully convinced QuickTags should stay but if they have to stay they should be accessible and not introduce accessibility regressions.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jun 1, 2017
@afercia
Copy link
Contributor Author

afercia commented Jun 1, 2017

See #761

@jasmussen
Copy link
Contributor

Given I just closed the quick tags ticket, I'm also going to take the liberty of closing this one. That can let us focus all the discussion around how to best handle #1733. If we need to — say we decide to include both codemirror and a plain textfield, we can reopen the quicktags tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Code Editor Handling the code view of the editing experience [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

2 participants