All notices should use a spokenMessage

[afercia]

The failure notices in packages/editor/src/store/effects/posts.js should also use a spokenMessage to produce an audible message in the ARIA live region. This should be pretty standard for all the notices and it's already implemented in some of them, for example the success notices.

Also, the string used for the spoken message should not include links. See for example

gutenberg/packages/editor/src/store/effects/posts.js

Lines 219 to 227 in a731af5

	if ( noticeMessage ) {
	dispatch( createSuccessNotice(
	<p>
	{ noticeMessage }
	{ ' ' }
	{ shouldShowLink && <a href={ post.link }>{ __( 'View post' ) }</a> }
	</p>,
	{ id: SAVE_POST_NOTICE_ID, spokenMessage: noticeMessage }
	) );

[afercia]

Seems there are a few more notices that need a spoken message:

• trashPostFailure
• a few ones in packages/editor/src/store/effects/reusable-blocks.js

[afercia]

Ah OK I understand better now. So, by default the audible message will be the string used for the visible message. Only if a different audible message is desired, then it's possible to use spokenMessage to differentiate it:

gutenberg/packages/editor/src/store/effects.js

Lines 212 to 215 in 7462c63

	CREATE_NOTICE( { notice: { content, spokenMessage } } ) {
	const message = spokenMessage || content;
	speak( message, 'assertive' );
	},

[aduth]

The behavior was changed in the introduction of the notices module in #9617 to make the displayed content align to the spoken text, by limiting the acceptable content of a notice to plaintext.

[gziolo]

@afercia is it still an issue?

@nerrad I noticed that you refactor the same codebase in #13716 that is referenced in this issue. It would be great to double check if this issue is resolved or plan how to resolve it.

[nerrad]

The refactor in #13716 is mostly preserving the existing behaviour in the code existing in master now. As @aduth mentioned, #9617 seems to be what would have had the most impact on this issue. So awaiting confirmation from @afercia, it looks to me like this issue shouldn't exist now?

[afercia]

To my understanding, all notices have now built-in ability to speak() their message (as long as the default option speak: true is not changed) so I guess this issue can be closed.