Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote block can lose cite tag #9180

Closed
collinanderson opened this issue Aug 20, 2018 · 8 comments
Closed

Quote block can lose cite tag #9180

collinanderson opened this issue Aug 20, 2018 · 8 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended

Comments

@collinanderson
Copy link

collinanderson commented Aug 20, 2018

To Reproduce
Steps to reproduce the behavior:

  1. Create a Quote Block
  2. type one letter in the citation
  3. switch to the main quote field (or press shift+tab)
  4. switch back to the citation (tab) and backspace that one letter
  5. switch to another field (shift+tab)
  6. try to switch back to citation field (tab)

Expected behavior
I get a blinking cursor on the citation field, or tab takes me to the empty paragraph block

Screenshots
( element is completely missing from the dom)
image

Desktop (please complete the following information):

  • OS: Mac 10.13.6 (17G65)
  • Browser: Chrome Version 68.0.3440.106 (Official Build) (64-bit)
    (also happens in firefox on mac, and chrome on windows)

Additional context

  • Gutenberg version 3.6.2
@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Aug 20, 2018
@designsimply
Copy link
Member

Tested and confirmed in Chrome 68.0.3440.106 using WordPress 4.9.8 and Gutenberg 3.6.2 but I didn't see the same bug happen when testing with Firefox 61.0.2. (36s)

HTML before:

<div class="components-autocomplete"><cite aria-label="Write citation…" aria-autocomplete="list" aria-expanded="false" role="textbox" aria-multiline="true" class="editor-rich-text__tinymce mce-content-body" contenteditable="true" data-is-placeholder-visible="false" id="mce_2"><br data-mce-bogus="1"></cite><div role="presentation"></div></div>

HTML after:

<div class="components-autocomplete"><br data-mce-bogus="1"></div>

data-mce-bogus
Seen at http://alittletestblog.com/wp-admin/post.php?post=14474&action=edit running WordPress 4.9.8 and Gutenberg 3.6.2 using Chrome 68.0.3440.106 on macOS 10.13.6. (1m13s)

Just for reference, can you note which version of Firefox you tested with?

@collinanderson
Copy link
Author

Firefox (on Mac)
Version 61.0.1
Build ID 20180704003137

@ellatrix
Copy link
Member

Can confirm. Looking for a fix.

@ellatrix
Copy link
Member

Seems to just happen when you delete the letter from the cite and then blur the field.

@ellatrix
Copy link
Member

The cause seems to be cite being an inline element and using that as a RichText container. If I use a div or footer, the problem seems to disappear.

@ellatrix
Copy link
Member

@designsimply @collinanderson Does #9195 fix the issue for you?

@collinanderson
Copy link
Author

collinanderson commented Aug 23, 2018

#8773 would fix this

@aduth
Copy link
Member

aduth commented Oct 5, 2018

Closed by #8785

@aduth aduth closed this as completed Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants