Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled error dialog is unstyled #8677

Closed
aduth opened this issue Aug 7, 2018 · 1 comment · Fixed by #8834
Closed

Unhandled error dialog is unstyled #8677

aduth opened this issue Aug 7, 2018 · 1 comment · Fixed by #8834
Assignees
@karmatosed @johngodley
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Bug An existing feature does not function as intended

Comments

@aduth
Copy link
Member

aduth commented Aug 7, 2018

Describe the bug

The unhandled error is intended to show as centered in a dialog prompt. This styling no longer occurs.

To Reproduce

Repeat steps from #8676

See:

screen shot 2018-08-07 at 2 39 25 pm

Expected behavior

Something more like (from #3208):

Error
@aduth aduth added [Type] Bug An existing feature does not function as intended Framework Issues related to broader framework topics, especially as it relates to javascript labels Aug 7, 2018
@aduth aduth mentioned this issue Aug 7, 2018
Merged
4 tasks
@aduth
Copy link
Member Author

aduth commented Aug 7, 2018

Regressed in #7866 , cc @johngodley @karmatosed

@youknowriad youknowriad mentioned this issue Aug 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karmatosed karmatosed

@johngodley johngodley

Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unhandled error dialog styling WordPress/gutenberg
3 participants
@karmatosed @johngodley @aduth