Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a "click on the block appender" test helper for e2e tests #8619

Closed
tofumatt opened this issue Aug 6, 2018 · 0 comments · Fixed by #8301
Closed

Create a "click on the block appender" test helper for e2e tests #8619

tofumatt opened this issue Aug 6, 2018 · 0 comments · Fixed by #8301
Assignees
@tofumatt
Labels
[Type] Code Quality Issues or PRs that relate to code quality

Comments

@tofumatt
Copy link
Member

tofumatt commented Aug 6, 2018

See:
#8301 (comment)

Basically, we do await page.click( '.editor-default-block-appender__content' ); in the e2e tests a lot, but really this could just be a test helper like await clickBlockAppender( page ). This change would:

  1. State the intent/action more clearly
  2. DRY up the code
@tofumatt tofumatt added the [Type] Code Quality Issues or PRs that relate to code quality label Aug 6, 2018
@tofumatt tofumatt self-assigned this Aug 6, 2018
@tofumatt tofumatt mentioned this issue Aug 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try to rewrite e2e tests using jest-puppeter preset WordPress/gutenberg
1 participant
@tofumatt