Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittently, multiple preview tabs are opened in the preview e2e test #8367

Closed
notnownikki opened this issue Aug 1, 2018 · 3 comments
Closed

Intermittently, multiple preview tabs are opened in the preview e2e test #8367

notnownikki opened this issue Aug 1, 2018 · 3 comments
Labels
Needs Testing Needs further testing to be confirmed. [Status] In Progress Tracking issues with work in progress [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended

Comments

@notnownikki
Copy link
Member

notnownikki commented Aug 1, 2018 •
edited
Loading

Describe the bug

See: https://github.com/WordPress/gutenberg/pull/8301/files#diff-46acebe2b5c3907767eb03ce378ad48fR106

To Reproduce

  1. Be me. Half joking here, but this is intermittent and of all the environments I've seen this happen in, it's most frequent on my baremetal linux setup.
  2. Remove the part of the code from the above commit that closes and opens the preview tab
  3. Run the test in non-headless mode (makes no difference, but you can see the effect)
  4. Sometimes, the test opens two preview tabs, and should not.

Expected behavior

There should only ever be one preview tab open.
@notnownikki notnownikki mentioned this issue Aug 1, 2018
Merged
@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. Needs Testing Needs further testing to be confirmed. labels Aug 1, 2018
@aduth
Copy link
Member

aduth commented Aug 13, 2018

Has this been resolved? Thinking by either #8301 and/or #8330

@aduth aduth added the [Status] In Progress Tracking issues with work in progress label Aug 13, 2018
@notnownikki
Copy link
Member Author

Will move this up on my list of things to check!

@notnownikki
Copy link
Member Author

Looks fine now! I've opened a PR to remove the workaround at #8928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Testing Needs further testing to be confirmed. [Status] In Progress Tracking issues with work in progress [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@designsimply @aduth @notnownikki