Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking Preview button opens a new tab after publish #8318

Closed
gziolo opened this issue Jul 31, 2018 · 0 comments · Fixed by #8330
Closed

Clicking Preview button opens a new tab after publish #8318

gziolo opened this issue Jul 31, 2018 · 0 comments · Fixed by #8330
Assignees
@aduth
Labels
[Feature] Saving Related to saving functionality [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended

Comments

@gziolo
Copy link
Member

gziolo commented Jul 31, 2018 •
edited
Loading

Describe the bug
Related #8301.

When trying to preview the post which was just published. It doesn't reuse previously generated preview tab.

To Reproduce
Steps to reproduce the behavior:

  1. Type something in the title field.
  2. Click the preview button.
  3. Go back to the editor.
  4. Publish post.
  5. Click the preview button.
  6. Go back to the editor.
  7. Type something in the title field.
  8. Click the preview button.
  9. It shouldn't open a new tab. It should reuse the existing one.

Expected behavior
It should reuse an existing preview tab.

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Chrome the latest (67) and chromium used by Puppeteer.

Additional context
It can be also noticed when running e2e tests. You can run it as follows:
PUPPETEER_HEADLESS=false npm run test-e2e test/e2e/specs/preview.test.js
@gziolo gziolo added [Type] Bug An existing feature does not function as intended [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Jul 31, 2018
@aduth aduth self-assigned this Jul 31, 2018
@aduth aduth added the [Feature] Saving Related to saving functionality label Jul 31, 2018
@aduth aduth mentioned this issue Jul 31, 2018
Merged
@gziolo gziolo mentioned this issue Aug 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aduth aduth

Labels
[Feature] Saving Related to saving functionality [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Saving: Open preview window before setting URL WordPress/gutenberg
2 participants
@gziolo @aduth