Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Losing Blockquote Citation / Data recovery when changing block type #809

Closed
mrwweb opened this issue May 16, 2017 · 3 comments
Closed

Losing Blockquote Citation / Data recovery when changing block type #809

mrwweb opened this issue May 16, 2017 · 3 comments

Comments

@mrwweb
Copy link

mrwweb commented May 16, 2017

I've noticed that when one changes a blockquote to another block type, the citation is lost. Here's a GIF:

image

This raises the general question of dataloss when changing between block types and whether the user can recover. This seems simple for something like the citation (why not just hang onto it?), but I realize that the same solution probably needs to exist for something like changing a photo gallery with 50 images to a heading.

Not fully understanding the technical issues here, I wonder whether it at least makes sense to maintain old block data until the user saves their changes. When considering what gets lost when changing, it's important to think of this as primarily an issue of error recovery, though the need to provide recovery would seem to fall off after the first minute, hour, and day.

@aduth
Copy link
Member

aduth commented May 16, 2017

Similar to #807, this appears to be specific to the now-unmaintained prototypes, not the plugin under active development. cc @jasmussen

@mrwweb
Copy link
Author

mrwweb commented May 16, 2017

Thanks for clarifying! Can instructions for finding and using the plugin get added to the README? I didn't realize there was a plugin as I had to step away from following this project for the last month. (sorry!)

Edit: realizing that the repo is the plugin. I'm a genius. Readme clarification might still be nice.

@jasmussen
Copy link
Contributor

Edit: realizing that the repo is the plugin. I'm a genius. Readme clarification might still be nice.

No absolutely needs clarification. It's sort of a soft-launch because it's still very early. Some of the efforts ongoing now might be to replace the prototypes with the new editor, which can actually work outside of wp-admin. See also #655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants