Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tips: move first tip from body to toolbar #8050

Closed
folletto opened this issue Jul 19, 2018 · 7 comments
Closed

Tips: move first tip from body to toolbar #8050

folletto opened this issue Jul 19, 2018 · 7 comments
Assignees
Labels
[Feature] NUX Anything that impacts the new user experience [Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone

Comments

@folletto
Copy link
Contributor

screen shot 2018-07-19 at 14 36 57

I was checking some documentation and I noticed that the first tip appearing on the screen points to the "(+)" icon on the body.

I want to review with you if that's the ideal position, compared to pointing out the same "(+)" in the top toolbar.

The reasoning I'm following is:

  1. The tip is covering the content, so it blocks the author to just start writing.
  2. It seems implying that one has to press "(+)" before starting, which is not the case.
  3. The plus on the page is already right where the attention of the author is, doesn't need further highlight, but the one in the top bar does.
  4. The top bar plus is somehow subdued yet we know it can be missed (especially without having a label). Having an initial highlight will help.

So while of course I'm opening this discussion because I think it would be more beneficial for the tip to point to the one in the toolbar, I'm also aware I might be missing some other factors that led to that decision... and if there aren't, maybe we can consider moving it.

Thanks!

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] NUX Anything that impacts the new user experience labels Jul 19, 2018
@mtias
Copy link
Member

mtias commented Jul 19, 2018

I want to review with you if that's the ideal position, compared to pointing out the same "(+)" in the top toolbar.

I agree.

@mtias mtias added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Jul 19, 2018
@mtias mtias added this to the 3.4 milestone Jul 19, 2018
@pento pento modified the milestones: 3.4, 3.5 Jul 30, 2018
@gziolo gziolo modified the milestones: 3.5, 3.6 Aug 8, 2018
@noisysocks noisysocks self-assigned this Aug 9, 2018
@noisysocks
Copy link
Member

noisysocks commented Aug 9, 2018

Here's how it would look:

local wordpress test_wp-admin_post-new php screen recording 3

Or, if we shortened the copy:

local wordpress test_wp-admin_post-new php screen recording 4

Let me know what y'all think.

Noting that if we do this we can revert #8642 since there'd no longer be a scenario where more than one instance of the same tip can appear.

@noisysocks noisysocks added the Needs Design Feedback Needs general design feedback. label Aug 9, 2018
@folletto
Copy link
Contributor Author

That's great! :D
I think the shortened copy can be nice, but I feel it removes useful information. So let's keep the long one for now?

Also question: the alignment is manual, or dependent on length? Because it's nice for the tip to be below, it creates a good balance with the toolbar at the top.

@noisysocks
Copy link
Member

Also question: the alignment is manual, or dependent on length? Because it's nice for the tip to be below, it creates a good balance with the toolbar at the top.

We could make it so that the tip always appears below the inserter like in the first screenshot above. Tips are positioned in the same way as all other Popovers in Gutenberg: you specify a position (e.g. "middle right") and it tries to position the content there but will move it around if it won't fit on the screen.

@folletto
Copy link
Contributor Author

Cool. If possible that would be my preference then. :)

@youknowriad
Copy link
Contributor

Moving to 3.7, please restore 3.6 if you think it can make the cut

@youknowriad youknowriad modified the milestones: 3.6, 3.7 Aug 15, 2018
@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Aug 21, 2018
@karmatosed
Copy link
Member

Let's go with this, I have some more ideas with Tips but think we can iterate from here. Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] NUX Anything that impacts the new user experience [Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

8 participants