Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed Block: giphy embeds switch from animated gif to html page when clicked #7872

Closed
mgalbritton opened this issue Jul 10, 2018 · 4 comments
Assignees
Labels
[Block] Embed Affects the Embed Block [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@mgalbritton
Copy link

Describe the bug
Within Gutenberg, if you add a giphy embed via the generic embed block, the properly gif will show but if you then click on the gif to adjust the layout, the image showing changes to the giphy homepage.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new post.
  2. Using the embed block, add a giphy link.
  3. See the gif embed
  4. Click on the embed to adjust the layout of the embed.
  5. Watch the gif change instead.
  6. Preview the post, and you will see the correct embed.

Expected behavior
I expected the same preview image to show consistently.

Screenshots
screen shot on 2018-07-10 at 14_23_15
screen shot on 2018-07-10 at 13_35_50
screen shot on 2018-07-10 at 13_36_09

Desktop (please complete the following information):

  • OS: High Sierra
  • Browser Chrome
  • Version 67.0.3396.99

Additional context
Gutenberg version 3.2.0

@mgalbritton mgalbritton changed the title Giphy Embed Does Not Preview Properly Bug- Giphy Embed Does Not Preview Properly Jul 10, 2018
@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Jul 11, 2018
@designsimply designsimply changed the title Bug- Giphy Embed Does Not Preview Properly Embed Block: giphy embeds switch from animated gif to html page when clicked Jul 12, 2018
@designsimply
Copy link
Member

Tested and confirmed that I clicking on an embedded giphy causes the display to change from the animated gif to the whole html page for said giphy.

screen shot 2018-07-12 at thu jul 12 4 15 06 pm
Seen at http://alittletestblog.com/wp-admin/post.php?post=13959&action=edit running WordPress 4.9.7 and Gutenberg 3.2.0 using Firefox 61.0.1 on macOS 10.13.5.

Sample embed url I used for testing: https://giphy.com/gifs/peanuts-charlie-brown-a-christmas-Vz1cEfM0VFpII

@cmartini
Copy link

Anyone on this or is there a workaround?

@notnownikki notnownikki added the [Block] Embed Affects the Embed Block label Oct 4, 2018
@notnownikki notnownikki self-assigned this Oct 4, 2018
@notnownikki
Copy link
Member

Embedded content in the editor is rendered inside the Sandbox component, which i an iframe with security restrictions applied.

To fix this, there needs to be an option to allow or prevent clicks going to the rendered content. I've assigned myself to work on this.

@youknowriad
Copy link
Contributor

This is fixed by #12981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants