Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit of "More options" block menu #7684

Closed
oandregal opened this issue Jul 3, 2018 · 8 comments
Closed

Audit of "More options" block menu #7684

oandregal opened this issue Jul 3, 2018 · 8 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@oandregal
Copy link
Member

oandregal commented Jul 3, 2018

This task is used to track consistency of the "More options" block menu, discuss and address the outstanding issues, if any:

more-menu-gut-gallery

Block / Menu option [Show / Hide] Block Settings Edit [as HTML / visually] Convert to blocks Duplicate Convert to [Shared / Regular] block Delete Shared Block Remove Block
Inline Image ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Paragraph ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
List ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Gallery ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Quote ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Image ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Heading ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Audio ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Cover image ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Subheading ✔️ if no sharedblock if sharedblock ✔️ if sharedblock ✔️
Cover image ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Custom HTML ✔️ #7466 enable it if no sharedblocks ✔️ ✔️ if sharedblock ✔️
Classic ✔️ if no sharedblock if no sharedblock ✔️ ✔️ #5941 disable it if sharedblock ✔️
Code ✔️ #6672 asks to enable it ✔️ ✔️ if sharedblock ✔️
Preformatted ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Pullquote ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Table ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Verse ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
More ✔️ if sharedblock ✔️ if sharedblock ✔️
Page break ✔️ ✔️ ✔️ if sharedblock ✔️
Button ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Columns (beta) ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Separator ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Spacer ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Text Columns ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
Shortcode ✔️ ✔️ ✔️ if sharedblock ✔️
Categories ✔️ ✔️ ✔️ if sharedblock ✔️
Latest Posts ✔️ ✔️ ✔️ if sharedblock ✔️
Embeds ✔️ if no sharedblock ✔️ ✔️ if sharedblock ✔️
@oandregal
Copy link
Member Author

@jasmussen @karmatosed @mtias While working on #7466 I've prepared this table to help us track issues if any.

The main actionable question I have is: should the Duplicate option be available at all times for the Subheading and More blocks?

@oandregal
Copy link
Member Author

cc @noisysocks as per #5941 in case you are aware of any other issues/cases

@Soean
Copy link
Member

Soean commented Jul 3, 2018

The main actionable question I have is: should the Duplicate option be available at all times for the Subheading and More blocks?

Both blocks have a supports attribute multiple: false, because they should only appear once per post. Also if they are shared bocks, they shouldn't be duplicatable.

@jasmussen
Copy link
Contributor

@nosolosw Solid work here, and I agree with Soean, if the block is not supposed to be used more than once, it would be nice to make the Duplicate menu item disabled in those situations. I wouldn't remove the item, I think it makes more sense that it's disabled, that helps the spatial memory by not shifting menus around.

@oandregal
Copy link
Member Author

Got it. So the more directly actionable item would be the contrary to what I've initially proposed: disable the Duplicate option for More and Subheading blocks when they are shared blocks, as to avoid having twice of them in a Gutenberg post. At the moment I can get two by:

  • create a More or Subheading block
  • click Convert to shared block and save
  • at this point, the duplicate option is shown in the options menu; click it to effectively have two of them in a post/page

An alternative could be to prevent them from becoming shared blocks altogether, but I guess there may be use cases where it'd be useful for a Subheading to become a shared block.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Jul 5, 2018
@oandregal
Copy link
Member Author

I've started working on fixing the Duplicate option bug at #7957

@mtias
Copy link
Member

mtias commented Jul 19, 2018

See also the final design proposal here: #7433

@designsimply designsimply added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Blocks Overall functionality of blocks labels Jul 20, 2018
@youknowriad
Copy link
Contributor

Seems like this issue served its purpose and now we should close it in favor of small actionable issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

7 participants