Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Treat Navigation Block as a synced block #68646

Closed
3 of 6 tasks
yogeshbhutkar opened this issue Jan 14, 2025 · 1 comment · May be fixed by #68647
Closed
3 of 6 tasks

Navigation Block: Treat Navigation Block as a synced block #68646

yogeshbhutkar opened this issue Jan 14, 2025 · 1 comment · May be fixed by #68647
Assignees
Labels
[Package] Block editor /packages/block-editor [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.

Comments

@yogeshbhutkar
Copy link
Contributor

Description

Splitting this out from here.

https://github.com/WordPress/gutenberg/blob/aa38b2205f7fcbe18c8f06f48b06ba0dcc183b08/packages/block-editor/src/components/use-block-display-information/index.js#L85C4-L86C65

In the code above, the logic does not account for the Navigation block as a synced block. However, this is inaccurate since the Navigation block is indeed synced.

This needs to be updated to correctly recognize the Navigation block as a synced block.

Step-by-step reproduction instructions

  1. Navigate to Site Editor.
  2. Create a Navigation Block.
  3. Notice, it's not treated like a synced block. (e.g. look at template part)

Screenshots, screen recording, code snippet

No response

Environment info

  • WordPress Version: 6.8-alpha-59361
  • Gutenberg Version: Trunk (aa38b22)
  • OS: macOS Sequoia

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@yogeshbhutkar yogeshbhutkar added the [Type] Bug An existing feature does not function as intended label Jan 14, 2025
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 14, 2025
@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Package] Block editor /packages/block-editor and removed [Type] Bug An existing feature does not function as intended labels Jan 14, 2025
@Mamaduka
Copy link
Member

@yogeshbhutkar, it looks like we've already got an issue for this - #49158, which can provide more historical context.

I'm going to close this as a duplicate. Let's continue the discussion there.

@Mamaduka Mamaduka added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed and removed [Status] In Progress Tracking issues with work in progress labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants