Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "Settings" panel of Page List block to use ToolsPanel instead of PanelBody #67932

Closed
fabiankaegy opened this issue Dec 13, 2024 · 3 comments · Fixed by #67903 or #68248
Closed
Assignees
Labels
[Block] Page List Affects the Page List Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@fabiankaegy
Copy link
Member

fabiankaegy commented Dec 13, 2024

Part of #67813

Convert the "Settings" panel of the Page List block to use the ToolsPanel instead of PanelBody

@t-hamano
Copy link
Contributor

If this block is inside a Navigation block, performing certain operations seems to break the block. Here are the steps to reproduce:

  • Activate the Twenty Twenty-Five theme.
  • Open any template.
  • Attempt to select the Page List block in the Navigation block.
  • The block should break.
c90f9ceaba79208fcb3147553c160d98.mp4

Probably because the hasVaue prop is not defined here. I will reopen this issue to resolve this issue.

@t-hamano
Copy link
Contributor

Update: The critical error was resolved in #68076, but ideally the spec for the ToolsPanelItem component might need to be changed, as commented here.

@aaronrobertshaw
Copy link
Contributor

Ideally the spec for the ToolsPanelItem component might need to be changed, as commented #67813 (comment).

In the case of the edit menu button for the Page List block, it shouldn't be being wrapped in ToolsPanelItem at all. Doing so will only add a useless menu item to the ToolsPanel menu. See this comment for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Page List Affects the Page List Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
3 participants