Numerous drag and drop issues

[ellatrix]

Description

Drag + scroll broken

Drop trigger scroll to different location

Can't drag within gallery

Wrongful forbidden sign

Undo after drag scroll to wrong location

Step-by-step reproduction instructions

See GIFs

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[talldan]

Lots of issues.

Drag + scroll broken

It looks like this line returns the wrong element and then the effect tries setting scroll position on an element that doesn't have a scroll bar. It's possible the element that has the editor scrollbar changed at some point:

gutenberg/packages/block-editor/src/components/block-draggable/use-scroll-when-dragging.js

Line 41 in 0f6ab5d

scrollParentYRef.current = getScrollContainer( event.target );

I think the element with the scrollbar is inside the iframe, and this hook listens for events on a button outside the iframe, so that might be a little interesting.

[ellatrix]

@talldan Does the our custom scroll-when-dragging even work still? As far as I'm testing, it seems to try to scroll the main document outside the iframe, not within the iframe, so it doesn't have any effect. And what we see is actually the browser's default scroll behaviour.

[talldan]

Does the our custom scroll-when-dragging even work still?

It doesn't work!

As far as I'm testing, it seems to try to scroll the main document outside the iframe, not within the iframe, so it doesn't have any effect.

Yep, same thing I was trying to explain above. I probably should've led with something a sentence like "it isn't working at all" 😄

[ellatrix]

Ah, sorry, I misunderstood :)