Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Non-synced Patterns' title/name in the Inserter list (synced patterns' names/titles are included) #67243

Open
skorasaurus opened this issue Nov 22, 2024 · 5 comments
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.

Comments

@skorasaurus
Copy link
Member

skorasaurus commented Nov 22, 2024

What problem does this address?

I am not sure if this behavior is intentional but I've been asked by my co-workers who are content editors why the names of synced patterns are included but non-synced patterns' names are omitted in the list of available patterns in the block inserter.

In the screenshot below, there are 3 synced patterns - each of their names are listed; and the indicator that they are synced with the purple symbol is very helpful) first; then the non-synced patterns are listed without their names.

Image

At the least, It is confusing and inconsistent that synced patterns' titles are included but the names of non-synced patterns are omitted in this list.

What is your proposed solution?

Ideally, include the names of non-synced patterns in the list.

@skorasaurus skorasaurus added [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement. labels Nov 22, 2024
@t-hamano
Copy link
Contributor

t-hamano commented Nov 23, 2024

Thanks for the report.

I believe that in the current pattern list, user-created patterns have a visual title, while theme-provided patterns have the title displayed as a tooltip:

Image

Admittedly, it's confusing that titles are displayed differently depending on the pattern.

In my opinion, there are two approaches:

  • Display a visual title for every pattern.
  • Display the title of every pattern as a tooltip. If the pattern is a synced pattern, display the title as Synced: {patternName}.

cc @WordPress/gutenberg-design @ntsekouras

@fcoveram
Copy link
Contributor

I'm drawn to display the title of every pattern. I can't think of a reason why hiding some.

@jarekmorawski
Copy link
Contributor

Display a visual title for every pattern.

Ditto. I'm working on a flow where the patterns look visually similar, but the real difference is in their use case and content. Descriptive names would make it easier for consumers to find the patterns they need.

@t-hamano
Copy link
Contributor

Thank you all for your feedback.

In fact, the pattern list displayed in the inserter is a component called BlockPatternList. This component is used in other places, and the title is displayed as a tooltip in some places.

Should we display a visual title in all of these places as well?

Zoom Out mode: Change design

User patterns have visual titles, while theme-provided patterns do not.

Image

Template Parts Block: Design Tab

Image

Template : Design Tab

Image

@jameskoster
Copy link
Contributor

As Aki illustrates these lists are reused quite a bit. This should be considered and factored in at the component level. See: #66549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants