Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataForm: Improve loading state management #66599

Closed
gigitux opened this issue Oct 30, 2024 · 0 comments · Fixed by #67694
Closed

DataForm: Improve loading state management #66599

gigitux opened this issue Oct 30, 2024 · 0 comments · Fixed by #67694
Assignees
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Package] DataViews /packages/dataviews [Status] In Progress Tracking issues with work in progress

Comments

@gigitux
Copy link
Contributor

gigitux commented Oct 30, 2024

While working on #66559, I noticed that the data loading state is not properly managed, as the value is a boolean. To improve this, we should enhance the loading state management. For DataViews, we use the isLoading prop; similarly, we need to implement an isLoading prop for DataForm.

@gigitux gigitux added [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Package] DataViews /packages/dataviews labels Oct 30, 2024
@gigitux gigitux self-assigned this Dec 6, 2024
@gigitux gigitux linked a pull request Dec 6, 2024 that will close this issue
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Package] DataViews /packages/dataviews [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant