Core Data: Restore registerSyncConfigs

[Mamaduka]

This is a follow-up task for #65871 (comment).

[youknowriad]

Can you clarify the question here, I'm not sure I understand. registerSyncConfigs calls are calls that should be done when entities are registered basically. Every time a new entity config is added and this entity has a "syncConfig", we should call the register for this entity.

[Mamaduka]

@youknowriad, just looking for the right place to restore it.

• At a glance, the getEntitiesConfig resolver seems like the right place, but it only has access to dynamically loaded entities.
• Next, the getEntitiesConfig selector could be used, but as @ellatrix pointed out, selectors are called excessively.

Every time a new entity config is added and this entity has a "syncConfig", we should call the register for this entity.

Based on this description, the addEntities action seems to be in the correct place. But that means we'll also have to run rootEntitiesConfig through it.

P.S. Hope my new ramble makes more sense 😅

[Mamaduka]

@youknowriad, any suggestions here?

[youknowriad]

Based on this description, the addEntities action seems to be in the correct place. But that means we'll also have to run rootEntitiesConfig through it.

This sounds like a good suggestion assuming we don't regress loading performance.

[Mamaduka]

I was thinking more about this, and the getEntitiesConfig seems like a good place for Core entities.

Can you think of any downsides to calling select.getEntitiesConfig inside its resolver?

cc @jsnajdr, @tyxla

[youknowriad]

Why do you think a selector/resolver is a good place to call an action to "register" something? It feels a bit weird no? Anyway, this is all experimental code that might change as well, so don't overthink it too much.

[Mamaduka]

The addEntities would require changing the whole initialization logic for static entities, which I'm worried might affect performance.