Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateTemplatePartModalContents: Refactor to not use RadioGroup #66569

Closed
mirka opened this issue Oct 29, 2024 · 0 comments · Fixed by #67702
Closed

CreateTemplatePartModalContents: Refactor to not use RadioGroup #66569

mirka opened this issue Oct 29, 2024 · 0 comments · Fixed by #67702
Assignees
@ciampo
Labels
[Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality

Comments

@mirka
Copy link
Member

mirka commented Oct 29, 2024

What problem does this address?

The RadioGroup component is deprecated (#45389), and this is the only instance of usage in the Gutenberg app. It's also heavily modified visually. It doesn't make sense to keep this around. Refactoring this usage away from RadioGroup will allow us to potentially soft or hard deprecate (#61099) RadioGroup.

Heavily modded RadioGroup

What is your proposed solution?

Use standard HTML instead of the RadioGroup component.
@mirka mirka added [Package] Editor /packages/editor [Type] Code Quality Issues or PRs that relate to code quality labels Oct 29, 2024
@mirka mirka mentioned this issue Oct 29, 2024
Merged
@ciampo ciampo mentioned this issue Dec 7, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciampo ciampo

Labels
[Package] Editor /packages/editor [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CreateTemplatePartModalContents: use native radio inputs WordPress/gutenberg
2 participants
@mirka @ciampo