Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Icons: incorrect block appender size #65766

Closed
2 tasks done
t-hamano opened this issue Oct 1, 2024 · 0 comments · Fixed by #65769
Closed
2 tasks done

Social Icons: incorrect block appender size #65766

t-hamano opened this issue Oct 1, 2024 · 0 comments · Fixed by #65769
Assignees
@t-hamano
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Oct 1, 2024 •
edited
Loading

Description

#64877 improved the block inserter in the Social Icons block. However, in Gutenberg trunk, the inserter doesn't seem to display correctly.

  • The inserter is not square.
  • When you increase the icon size, the plus sign becomes invisible.

I have also confirmed that this issue was caused by #65225.

Note: This issue does not exist in WP 6.7 Beta1.

Step-by-step reproduction instructions

  • Insert a Social Icons block.
  • Change size.

Screenshots, screen recording, code snippet

Gutenberg (40ceb00)

gutenberg.mp4

WordPress 6.7 Beta 1

wp6.7-beta1.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Social Affects the Social Block - used to display Social Media accounts labels Oct 1, 2024
@t-hamano t-hamano mentioned this issue Oct 1, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-hamano t-hamano

Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Social Links: Fix block appender size WordPress/gutenberg
1 participant
@t-hamano