-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review the wording of the pre-publish panel description when submitting for review as a contributor #65368
Comments
@afercia I have come up with some suggestions to modify the message
I personally feel the 1st one will be good for the following reasons
To enhance this further we can make the message dynamic. I'll be raising a PR for the 1st suggestion with the suggested enhancement, however we can always change if we feel the need to. |
Good suggestions. I think we can shorten it to: It's not necessary to add the role and repeat that it will be submitted for review, because that's already said in the button and heading. |
@hanneslsm On it. |
Just a suggestion, we can also keep it as |
Thanks all for looking into this. Personally, I'd prefer the shorter version. |
@afercia
|
Good suggestions. What about entirely avoiding to mention other users? Something like:
|
I feel using the word "user" is necessary since, now-a-days it can be assumed that the post can be reviewed by an AI tool too. |
also as @hanneslsm said we should avoid using "Submit your work" since that will introduce redundancy |
IMHO, any reference to
Overall, I'd think the message should avoid technical terms and just commuicate the concept 'submit and it will be reviewed'. |
What about
|
👍🏻 for 2 from my side. The shorter, the better. |
@afercia On it. |
I have updated the code. |
Thanks @sarthaknagoshe2002 ! Can you please add 'before and after' screenshots on the PR #67328 so that other contributors can quickly check the change? Thanks! |
@afercia I have updated the PR description. |
Description
When users with the
contributor
role submit a post for review, the pre-publish panel shows the following description:The description text is:
When you’re ready, submit your work for review, and an Editor will be able to approve it for you.
The wording assumes the other user who will review is an Editor. The uppercase E hints it's an user with
role
editor, which may or may not be true. Actually, any user with the publish capability may review and publish. Instead, the current wording assumes it's an Editor role. This is inaccurate and should be changed.Minor:
I'm not sure
When you’re ready
at the beginning of the sentence is necessary. As a contributor user I already clicked the first button 'Submit for Review`. It's likely I already determined I'm ready to submit.Step-by-step reproduction instructions
Submit for Review
.Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Please confirm that you have tested with all plugins deactivated except Gutenberg.
The text was updated successfully, but these errors were encountered: