Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload external media replaces images in wrong order and/or creates duplicates #65281

Closed
2 tasks done
traed opened this issue Sep 12, 2024 · 5 comments
Closed
2 tasks done
Labels
[Feature] Media Anything that impacts the experience of managing media [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended

Comments

@traed
Copy link

traed commented Sep 12, 2024

Description

When copy-pasting content with several images from e.g. google docs and hitting Publish, an option to upload external images appears. Sometimes when using it the images in the editor gets replaces by the wrong image after the upload is done. So that if a document had images A, B and C, after the upload is done B and C are replaces by copies of A.

Step-by-step reproduction instructions

  1. Copy all content from a google doc with multiple different images
  2. Paste it into the WP editor
  3. Hit publish and then Upload when prompted
  4. After the upload is done the images in the editor are replaces incorrectly

Screenshots, screen recording, code snippet

Google doc with example content: https://docs.google.com/document/d/1FSNt8QQFofPu27PvoUOo7Gwq1hedkoNoD1t2_KuSFAo/edit?usp=sharing

Screen recording: https://drive.google.com/file/d/1O2WXbaTrGUHFUmToyc8iYdVPsIjmNncv/view?usp=sharing

Environment info

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@traed traed added the [Type] Bug An existing feature does not function as intended label Sep 12, 2024
@Mamaduka Mamaduka added [Feature] Media Anything that impacts the experience of managing media [Package] Editor /packages/editor labels Sep 12, 2024
@Mamaduka
Copy link
Member

Thanks for reporting the issue, @traed!

This looks similar to #64899, which was fixed via #65122.

cc @sgomes

@sgomes
Copy link
Contributor

sgomes commented Sep 12, 2024

Thank you for the mention, @Mamaduka! 👍 Yes, that does indeed seem like a similar issue to #64899, I agree.

@traed: If you have the opportunity to give trunk a try, please let me know if that fixes things for you!

@Mamaduka
Copy link
Member

@traed, @sgomes, I just tested using trunk and provided test Google Document. The images are uploaded and replaced correctly.

@sgomes
Copy link
Contributor

sgomes commented Sep 12, 2024

Thank you so much, @Mamaduka! 🙌

@Mamaduka
Copy link
Member

I'm going to close the issue. The bug has been fixed in Gutenberg trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants