Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove purple coloring from DocumentBar #65168

Closed
richtabor opened this issue Sep 9, 2024 · 2 comments · Fixed by #66451
Closed

Remove purple coloring from DocumentBar #65168

richtabor opened this issue Sep 9, 2024 · 2 comments · Fixed by #66451
Assignees
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

As an affordance, the purple color applied in the DocumentBar is not helping to communicate the "global" nature of templates, synced patterns, and template parts. It's just not connective in this presentation, and with the addition of post type labels in #65167 — arguably, not necessary.

I propose we simplify a bit, removing the purple color within the DocumentBar.

Current

current

Proposed

proposed
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. labels Sep 9, 2024
@creativecoder
Copy link
Contributor

Looking at this, I see we use color: var(--wp-block-synced-color); in a number of other places, too, here are some that I found:

List View Template Parts
image

Template Part Block Toolbar
image

Template Part Block Info
image

Template Title
image


I think this should be consistent, e.g. if the color isn't used for template text in the DocumentBar, then don't use it in the Template info (sidebar) either.

Same for the icon, (unless it's removed from the DocumentBar, see #65167)

@richtabor
Copy link
Member Author

I think this should be consistent, e.g. if the color isn't used for template text in the DocumentBar, then don't use it in the Template info (sidebar) either.

This yes, but the template part block icon is block-level, so I think it's fine to leave it purple in canvas—for now at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants